From: Felipe Balbi <balbi@kernel.org>
To: Joel Pepper <joel.pepper@rwth-aachen.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Paul Elder <paul.elder@pitt.edu>
Subject: [v5,1/2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first
Date: Thu, 22 Mar 2018 10:55:02 +0200 [thread overview]
Message-ID: <87a7v0pk0p.fsf@linux.intel.com> (raw)
Hi,
Joel Pepper <joel.pepper@rwth-aachen.de> writes:
> - Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size.
> - Automatically assign ascending bFrameIndex to each frame in a format.
>
> Before all "bFrameindex" attributes were set to "1" with no way to
> configure the gadget otherwise. This resulted in the host always
> negotiating for bFrameIndex 1 (i.e. the first framesize of the gadget).
> After the negotiation the host driver will set the user or application
> selected framesize, while the gadget is actually set to the first
> framesize.
>
> Now, when the containing format is linked into the streaming header,
> iterate over all child frame descriptors and assign ascending indices.
> The automatically assigned indices can be read from the new read only
> bFrameIndex configsfs attribute in each frame descriptor item.
>
> v2: Add the new attribute to both MJPEG and uncompressed frame descriptors
> in Documentation/ABI, with note that it was added only in a later
> kernel version
>
> v3: Changed from simply allowing user to set the value for bFrameIndex to
> automatically assigning correct distinct frame indexes. Changed
> bFrameIndex from RW to RO
>
> v4: Actually include updated patch
>
> v5: bFrameIndex now returns -EBUSY if the parent fmt is not linked yet
>
> Signed-off-by: Joel Pepper <joel.pepper@rwth-aachen.de>
no Ack from Laurent yet? hmm, I'll have to delay this one for the next
merge window, sorry. Just as a side note, version changes (v2, v3, v4,
v5 above) should comer after the tearline (---) below. We don't need
these changes in the commit log, it's just for maintainers to read :-)
If we had an ack from Laurent, I'd fix that while applying, but since
you're gonna have to resend anyway, please fix that once we get an Ack
from Laurent.
next reply other threads:[~2018-03-22 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 8:55 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-21 14:25 [v5,1/2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first Joel Pepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7v0pk0p.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel.pepper@rwth-aachen.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-usb@vger.kernel.org \
--cc=paul.elder@pitt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).