From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kit Dallege <xaum.io@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] usb: typec: add kernel-doc for priority and mode_selection members
Date: Mon, 16 Mar 2026 13:04:56 +0100 [thread overview]
Message-ID: <87b4bd3e-2287-423a-bc6f-ba6c0a516665@kernel.org> (raw)
In-Reply-To: <2026031638-deviant-granddad-9ae8@gregkh>
On 16/03/2026 07:17, Greg Kroah-Hartman wrote:
> On Sun, Mar 15, 2026 at 03:57:41PM +0100, Kit Dallege wrote:
>> Document the priority and mode_selection members of struct
>> typec_altmode that were added without kernel-doc descriptions.
>>
>> This fixes the following warnings when building with W=1:
>>
>> include/linux/usb/typec_altmode.h: struct member 'priority' not described in 'typec_altmode'
>> include/linux/usb/typec_altmode.h: struct member 'mode_selection' not described in 'typec_altmode'
>>
>> Signed-off-by: Kit Dallege <xaum.io@gmail.com>
>> Signed-off-by: kovan <xaum.io@gmail.com>
>
> Please use your name, not an alias, to sign off on a patch. And no need
> to list it twice.
>
> Also, where are the other 5 patches here?
FWIW, other postings from this author were called as AI slop, so the
contents should be thoroughly reviewed.
https://lore.kernel.org/all/?q=f%3A%22Kit+Dallege%22
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-16 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 14:57 [PATCH 2/5] usb: typec: add kernel-doc for priority and mode_selection members Kit Dallege
2026-03-16 6:17 ` Greg Kroah-Hartman
2026-03-16 12:04 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87b4bd3e-2287-423a-bc6f-ba6c0a516665@kernel.org \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xaum.io@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox