From: Felipe Balbi <balbi@kernel.org>
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
Lee Jones <lee.jones@linaro.org>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
Ben Dooks <ben@simtec.co.uk>
Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
Date: Tue, 21 Jul 2020 12:43:57 +0300 [thread overview]
Message-ID: <87blk9p5ia.fsf@kernel.org> (raw)
In-Reply-To: <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:
> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> value. Looks like this has been broken since
>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>>
>> Also fixes the following W=1 warning:
>>
>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>> 259 | u32 gintmsk2;
>> | ^~~~~~~~
>>
>> Cc: Minas Harutyunyan <hminas@synopsys.com>
>> Cc: Ben Dooks <ben@simtec.co.uk>
>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by: Minas Harutyunyan <hminas@synopsys.com>
Should I apply the entire series or only 1/8?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-07-21 9:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 9:32 [PATCH v2 0/8] Mop-up left-behind fixes for W=1 warnings in USB Lee Jones
2020-07-15 9:32 ` [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 Lee Jones
2020-07-15 12:23 ` Minas Harutyunyan
2020-07-21 9:43 ` Felipe Balbi [this message]
2020-07-21 10:09 ` Minas Harutyunyan
2020-07-21 11:32 ` Felipe Balbi
2020-07-21 11:52 ` Lee Jones
2020-07-21 11:55 ` Felipe Balbi
2020-07-15 9:32 ` [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control register Lee Jones
2020-07-15 9:32 ` [PATCH v2 3/8] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc Lee Jones
2020-07-15 9:32 ` [PATCH v2 4/8] usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file Lee Jones
2020-07-15 9:32 ` [PATCH v2 5/8] usb: class: cdc-wdm: Provide description for usb_cdc_wdm_register()'s manage_power arg Lee Jones
2020-07-15 9:32 ` [PATCH v2 6/8] usb: c67x00: c67x00-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-15 9:32 ` [PATCH v2 7/8] usb: misc: sisusbvga: sisusb_init: Remove genunine unused static const arrays Lee Jones
2020-07-15 9:32 ` [PATCH v2 8/8] usb: misc: sisusbvga: Move static const tables out to different include file Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blk9p5ia.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=ben@simtec.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).