From: Felipe Balbi <balbi@kernel.org>
To: Bin Liu <b-liu@ti.com>
Cc: Roger Quadros <rogerq@ti.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: turn off VBUS when leaving host mode
Date: Wed, 11 Dec 2019 16:41:50 +0200 [thread overview]
Message-ID: <87blseyle9.fsf@kernel.org> (raw)
In-Reply-To: <20191210134815.GC26131@uda0271908>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hi,
Bin Liu <b-liu@ti.com> writes:
>> > de-assert DRVVBUS. If left GCTL[PRTCAP] to OTG, grounding the ID pin
>> > would make the controller to assert DRVVBUS without any software
>> > involved. So the fix should be the following. Please let me know you
>> > comments.
>>
>> But that's expected, no? If port is OTG, then it must obey ID pin rules
>> specified by OTG. IIRC, dwc3 is OTG 2.x compliant, at least the version
>> TI uses.
>
> It is expected when the usb drivers are bind to the controller. I am
> trying to solve the issue that DRVVBUS is still asserted on both host
> port and otg port with ID pin grounded when the drivers are unbind from
> the controller (after modprobe -r dwc3-omap, DRVVBUS should be
> de-asserted).
I see. Now I understand the scenario. Thanks for the explanation, Bin.
Care to send an up-to-date patch so I can queue it?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-12-11 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 14:15 [PATCH] usb: dwc3: turn off VBUS when leaving host mode Bin Liu
2019-11-14 8:48 ` Roger Quadros
2019-11-14 14:16 ` Bin Liu
2019-11-18 7:07 ` Felipe Balbi
2019-11-18 9:51 ` Roger Quadros
2019-12-02 7:41 ` Felipe Balbi
2019-12-09 17:15 ` Bin Liu
2019-12-10 11:50 ` Felipe Balbi
2019-12-10 13:48 ` Bin Liu
2019-12-11 14:41 ` Felipe Balbi [this message]
2019-12-11 16:10 ` [PATCH v2] " Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blseyle9.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=b-liu@ti.com \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).