linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
	gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org
Subject: [2/2] USB: show USB3 Gen XxY version during device enumeration
Date: Tue, 13 Mar 2018 17:31:49 +0200	[thread overview]
Message-ID: <87bmfs56vu.fsf@linux.intel.com> (raw)

Hi,

Mathias Nyman <mathias.nyman@linux.intel.com> writes:
> USB 3.2 specification adds a Gen XxY notion for USB3 devices where
> X is the signaling rate on the wire. Gen 1xY is 5Gbps Superspeed
> and Gen 2xY is 10Gbps SuperSpeedPlus. Y is the lane count.
> USB 3.2 supports dual lane Gen Xx2
>
> Gen 1x1 5Gbps  single lane
> Gen 2x1 10Gbps single lane
> Gen 1x2 10Gbps dual lane  (USB 3.2)
> Gen 2x2 20Gbps dual lane  (USB 3.2)
>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
>  drivers/usb/core/hub.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 853516d..c203876 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -4592,9 +4592,11 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
>  			if (udev->speed >= USB_SPEED_SUPER) {
>  				devnum = udev->devnum;
>  				dev_info(&udev->dev,
> -						"%s SuperSpeed%s USB device number %d using %s\n",
> +						"%s SuperSpeed%s Gen %dx%d USB device number %d using %s\n",
>  						(udev->config) ? "reset" : "new",
>  					 (udev->speed == USB_SPEED_SUPER_PLUS) ? "Plus" : "",
> +					 (udev->speed == USB_SPEED_SUPER_PLUS) ? 2 : 1,

SuperSpeedPlus is not a Synonym to Gen2, is it? Perhaps Gen XxY should
be printed at a later time when you finally have Speed and Lane count
for both RX and TX sides?

             reply	other threads:[~2018-03-13 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 15:31 Felipe Balbi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-13 15:56 [2/2] USB: show USB3 Gen XxY version during device enumeration Mathias Nyman
2018-03-13 15:27 Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmfs56vu.fsf@linux.intel.com \
    --to=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).