From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Remove incomplete check
Date: Sun, 15 Mar 2020 11:19:02 +0200 [thread overview]
Message-ID: <87d09ef01l.fsf@kernel.org> (raw)
In-Reply-To: <660a74249e64b3b62ca9b394584387baee67a119.1583466150.git.thinhn@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
Hi,
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> We only care to resume transfer for SG because the request maybe
> partially completed. dwc3_gadget_ep_request_completed() doesn't check
> that of a request, at least not fully.
>
> 1) It doesn't account for OUT direction.
> 2) It doesn't account for isoc. For isoc, a request maybe completed with
> partial data.
I would rather fix the function for these cases instead of removing it
completely. While at that, also move the req->num_pending_sgs check
inside dwc3_gadget_ep_request_completed()
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-03-15 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 3:44 [PATCH] usb: dwc3: gadget: Remove incomplete check Thinh Nguyen
2020-03-15 9:19 ` Felipe Balbi [this message]
2020-03-16 0:33 ` Thinh Nguyen
2020-03-16 7:00 ` Felipe Balbi
2020-03-16 20:37 ` Thinh Nguyen
2020-03-29 8:03 ` Felipe Balbi
2020-03-29 23:44 ` Thinh Nguyen
2020-03-30 8:26 ` Felipe Balbi
2020-03-30 19:30 ` Thinh Nguyen
2020-03-30 21:34 ` Felipe Balbi
2020-03-31 1:47 ` Thinh Nguyen
2020-03-31 8:12 ` Felipe Balbi
2020-03-31 8:39 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09ef01l.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).