From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02027C0650E for ; Wed, 3 Jul 2019 11:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7BBB218A3 for ; Wed, 3 Jul 2019 11:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726811AbfGCLiL (ORCPT ); Wed, 3 Jul 2019 07:38:11 -0400 Received: from mga04.intel.com ([192.55.52.120]:24548 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbfGCLiK (ORCPT ); Wed, 3 Jul 2019 07:38:10 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 04:38:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="184728002" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2019 04:38:08 -0700 From: Felipe Balbi To: Martin Blumenstingl Cc: "linux-usb\@vger.kernel.org" , Minas Harutyunyan , "linux-kernel\@vger.kernel.org" , linux-stable , "gregkh\@linuxfoundation.org" Subject: Re: [PATCH] usb: dwc2: use a longer AHB idle timeout in dwc2_core_reset() In-Reply-To: References: <20190620175022.29348-1-martin.blumenstingl@googlemail.com> Date: Wed, 03 Jul 2019 14:38:07 +0300 Message-ID: <87d0ir4acg.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Martin Blumenstingl writes: > On Mon, Jul 1, 2019 at 7:54 PM Martin Blumenstingl > wrote: >> >> On Mon, Jun 24, 2019 at 7:41 AM Minas Harutyunyan >> wrote: >> > >> > On 6/20/2019 9:51 PM, Martin Blumenstingl wrote: >> > > Use a 10000us AHB idle timeout in dwc2_core_reset() and make it >> > > consistent with the other "wait for AHB master IDLE state" ocurrences. >> > > >> > > This fixes a problem for me where dwc2 would not want to initialize when >> > > updating to 4.19 on a MIPS Lantiq VRX200 SoC. dwc2 worked fine with >> > > 4.14. >> > > Testing on my board shows that it takes 180us until AHB master IDLE >> > > state is signalled. The very old vendor driver for this SoC (ifxhcd) >> > > used a 1 second timeout. >> > > Use the same timeout that is used everywhere when polling for >> > > GRSTCTL_AHBIDLE instead of using a timeout that "works for one board" >> > > (180us in my case) to have consistent behavior across the dwc2 driver. >> > > >> > > Cc: linux-stable # 4.19+ >> > > Signed-off-by: Martin Blumenstingl >> > > --- >> > >> > Acked-by: Minas Harutyunyan >> thank you for reviewing this! >> >> is there any chance we can get this fix into Linux 5.3? I know that >> it's too late for 5.2 so I'm fine with skipping that. > thank you Felipe for queuing this for v5.3! > for reference, this patch is now in the usb-for-v5.3-part2 tag: [0] > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=usb-for-v5.3-part2&id=dfc4fdebc5d62ac4e2fe5428e59b273675515fb2 I'll send pull request soon :-) -- balbi