From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: TODO advice for octeon-usb?
Date: Tue, 21 May 2019 09:12:41 +0300 [thread overview]
Message-ID: <87d0kcibdy.fsf@linux.intel.com> (raw)
In-Reply-To: <20190520230532.GA3621@darkstar.musicnaut.iki.fi>
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
Hi,
Aaro Koskinen <aaro.koskinen@iki.fi> writes:
> I'm looking for input what should be done next to get
> drivers/staging/octeon-usb out of staging.
>
> Thousands of checkpatch errors/warnings have been fixed (starting point
> was <https://marc.info/?l=linux-driver-devel&m=137028876225266&w=2>),
> also the size of the driver has shrunken considerably.
>
> If there are still some other bigger issues with this driver, please
> let me know.
Looks pretty clean to me. I would simply break that single file into
smaller files if possible (see xhci/ehci for example).
my 2 cents
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-05-21 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 23:05 TODO advice for octeon-usb? Aaro Koskinen
2019-05-21 6:12 ` Felipe Balbi [this message]
2019-05-21 7:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0kcibdy.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=aaro.koskinen@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).