Linux USB
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Lars Melin <larsm17@gmail.com>
Cc: sven@svenschwermer.de, linux-usb@vger.kernel.org,
	Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
	linux-kernel@vger.kernel.org, oliver@neukum.org
Subject: Re: [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem
Date: Fri, 08 Apr 2022 15:35:13 +0200	[thread overview]
Message-ID: <87ee27y9ym.fsf@miraculix.mork.no> (raw)
In-Reply-To: <3b8a8497-df41-8bf4-6816-f4419cb7f950@gmail.com> (Lars Melin's message of "Fri, 8 Apr 2022 08:15:00 +0700")

Lars Melin <larsm17@gmail.com> writes:

> Why do you add this modem to the whitelist?

I believe the clue is the

> +	.driver_info = (unsigned long)&wwan_info,

to set FLAG_WWAN instead of the default FLAG_ETHER | FLAG_POINTTOPOINT

> The net interface has the correct cdc_ether attributes so the
> cdc_ether driver should bind automagically without any need for the
> modem to be in the whitelist.

Yes, this sort of works against the class driver philosophy.  But we've
already started down that road, so...



Bjørn

  reply	other threads:[~2022-04-08 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  7:47 [PATCH v1 1/2] net: usb: cdc_ether: Add Fibocom L610 modem sven
2022-04-07  7:47 ` [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem sven
2022-04-08  1:15   ` Lars Melin
2022-04-08 13:35     ` Bjørn Mork [this message]
2022-04-08 18:54       ` Sven Schwermer
2022-04-08  1:23 ` [PATCH v1 1/2] net: usb: cdc_ether: Add Fibocom L610 modem Lars Melin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee27y9ym.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=sven.schwermer@disruptive-technologies.com \
    --cc=sven@svenschwermer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox