From: Felipe Balbi <balbi@kernel.org>
To: rickyniu <rickyniu@google.com>,
gregkh@linuxfoundation.org, astrachan@google.com,
rickyniu@google.com, amit.pundir@linaro.org,
lockwood@android.com, benoit@android.com, jackp@codeaurora.org,
vvreddy@codeaurora.org
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
kyletso@google.com
Subject: Re: [PATCH 0/3] f_accessory upstream
Date: Mon, 12 Oct 2020 18:39:52 +0300 [thread overview]
Message-ID: <87eem3lagn.fsf@kernel.org> (raw)
In-Reply-To: <20201012111024.2259162-1-rickyniu@google.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
Hi,
rickyniu <rickyniu@google.com> writes:
> Below commit is to add log and send uevent:
> 0003-ANDROID-usb-f_accessory-send-uevent-for-51-52-reques.patch
if you're sending something new...
> Benoit Goby (1):
> ANDROID: usb: gadget: f_accessory: Add Android Accessory function
>
> Vijayavardhan Vennapusa (1):
> ANDROID: USB: f_accessory: Check dev pointer before decoding ctrl
> request
>
> rickyniu (1):
> ANDROID: usb: f_accessory: send uevent for 51,52 requests
why do you send me a broken version with two fixes? Send me a single
patch. Also, please correct the subject line for the patch to match
what's used in the framework. Something like:
usb: gadget: function: add Android Accessory function
should do the trick
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
prev parent reply other threads:[~2020-10-12 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 11:10 [PATCH 0/3] f_accessory upstream rickyniu
2020-10-12 11:10 ` [PATCH 1/3] ANDROID: usb: gadget: f_accessory: Add Android Accessory function rickyniu
2020-10-12 11:24 ` Greg KH
2020-10-12 11:28 ` Greg KH
2020-10-12 15:58 ` Felipe Balbi
2020-10-12 11:10 ` [PATCH 2/3] ANDROID: USB: f_accessory: Check dev pointer before decoding ctrl request rickyniu
2020-10-12 11:10 ` [PATCH 3/3] ANDROID: usb: f_accessory: send uevent for 51,52 requests rickyniu
2020-10-12 11:23 ` Greg KH
2020-10-12 11:28 ` Greg KH
2020-10-12 11:29 ` [PATCH 0/3] f_accessory upstream Greg KH
2020-10-12 15:39 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eem3lagn.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=astrachan@google.com \
--cc=benoit@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lockwood@android.com \
--cc=rickyniu@google.com \
--cc=vvreddy@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).