From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Neill Kapron <nkapron@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: avoid redundant strlen() in make_name_string()
Date: Tue, 17 Nov 2026 19:10:40 +0100 [thread overview]
Message-ID: <87fqwzxra7.wl-tiwai@suse.de> (raw)
In-Reply-To: <87jymbxs8k.wl-tiwai@suse.de>
On Tue, 17 Nov 2026 18:50:03 +0100,
Takashi Iwai wrote:
>
> On Tue, 17 Nov 2026 18:02:07 +0100,
> Dmitry Antipov wrote:
> >
> > In make_name_string(), prefer strchrnul() over strchr() to
> > avoid redundant call to strlen().
> >
> > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> > ---
> > drivers/usb/gadget/function/f_midi2.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/function/f_midi2.c b/drivers/usb/gadget/function/f_midi2.c
> > index d693de427641..76738ea55dba 100644
> > --- a/drivers/usb/gadget/function/f_midi2.c
> > +++ b/drivers/usb/gadget/function/f_midi2.c
> > @@ -2101,11 +2101,10 @@ static void make_name_string(char *s)
> > {
> > char *p;
> >
> > - p = strchr(s, '\n');
> > - if (p)
> > + p = strchrnul(s, '\n');
> > + if (*p)
> > *p = 0;
> >
> > - p = s + strlen(s);
> > for (; p > s && isspace(*p); p--)
> > *p = 0;
> > }
>
> Hmm, does it really result in the same? Wouldn't you need to
> decrement p at first before the loop?
... and looking again, I think it's a bug in my original code ;)
> And I guess this can be better replaced with strim().
... which can be fixed by replacing with strim() gracefully.
Care to resubmit as a fix?
thanks,
Takashi
prev parent reply other threads:[~2026-11-17 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:02 [PATCH] usb: gadget: avoid redundant strlen() in make_name_string() Dmitry Antipov
2026-11-17 17:10 ` sashiko-bot
2026-11-17 17:50 ` Takashi Iwai
2026-11-17 18:10 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fqwzxra7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dmantipov@yandex.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=nkapron@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox