From: Felipe Balbi <balbi@kernel.org>
To: Zhiwei Yang <yangzhiwei@uniontech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: phy: tahvo:remove unnecessary debug log
Date: Fri, 24 Sep 2021 13:23:55 +0300 [thread overview]
Message-ID: <87fstuqngk.fsf@kernel.org> (raw)
In-Reply-To: <20210924083852.6029-1-yangzhiwei@uniontech.com>
Hi,
Zhiwei Yang <yangzhiwei@uniontech.com> writes:
> Remove the debug info which should be instead with ftrace
why?
> Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
> ---
> drivers/usb/phy/phy-tahvo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index 5dc600fadc5f..468151496d23 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
> -
> mutex_lock(&tu->serialize);
>
> if (host == NULL) {
> @@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
is this causing any problems? What sort of problems? Why should we take
this patch?
--
balbi
next prev parent reply other threads:[~2021-09-24 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 8:38 [PATCH] USB: phy: tahvo:remove unnecessary debug log Zhiwei Yang
2021-09-24 10:04 ` Sergey Shtylyov
2021-09-24 10:23 ` Felipe Balbi [this message]
2021-09-24 10:28 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fstuqngk.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=yangzhiwei@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox