* [PATCH] USB: phy: tahvo:remove unnecessary debug log
@ 2021-09-24 8:38 Zhiwei Yang
2021-09-24 10:04 ` Sergey Shtylyov
2021-09-24 10:23 ` Felipe Balbi
0 siblings, 2 replies; 4+ messages in thread
From: Zhiwei Yang @ 2021-09-24 8:38 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman; +Cc: linux-usb, Zhiwei Yang
Remove the debug info which should be instead with ftrace
Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
---
drivers/usb/phy/phy-tahvo.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index 5dc600fadc5f..468151496d23 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
phy);
- dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
-
mutex_lock(&tu->serialize);
if (host == NULL) {
@@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
phy);
- dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
-
mutex_lock(&tu->serialize);
if (!gadget) {
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] USB: phy: tahvo:remove unnecessary debug log
2021-09-24 8:38 [PATCH] USB: phy: tahvo:remove unnecessary debug log Zhiwei Yang
@ 2021-09-24 10:04 ` Sergey Shtylyov
2021-09-24 10:23 ` Felipe Balbi
1 sibling, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2021-09-24 10:04 UTC (permalink / raw)
To: Zhiwei Yang, Felipe Balbi, Greg Kroah-Hartman; +Cc: linux-usb
On 24.09.2021 11:38, Zhiwei Yang wrote:
> Remove the debug info which should be instead with ftrace
>
> Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
> ---
> drivers/usb/phy/phy-tahvo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index 5dc600fadc5f..468151496d23 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
> -
Moreover, "%p" doesn't print a real address since 4.15.
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] USB: phy: tahvo:remove unnecessary debug log
2021-09-24 8:38 [PATCH] USB: phy: tahvo:remove unnecessary debug log Zhiwei Yang
2021-09-24 10:04 ` Sergey Shtylyov
@ 2021-09-24 10:23 ` Felipe Balbi
2021-09-24 10:28 ` Felipe Balbi
1 sibling, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2021-09-24 10:23 UTC (permalink / raw)
To: Zhiwei Yang; +Cc: Greg Kroah-Hartman, linux-usb
Hi,
Zhiwei Yang <yangzhiwei@uniontech.com> writes:
> Remove the debug info which should be instead with ftrace
why?
> Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
> ---
> drivers/usb/phy/phy-tahvo.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index 5dc600fadc5f..468151496d23 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
> -
> mutex_lock(&tu->serialize);
>
> if (host == NULL) {
> @@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
> phy);
>
> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
is this causing any problems? What sort of problems? Why should we take
this patch?
--
balbi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] USB: phy: tahvo:remove unnecessary debug log
2021-09-24 10:23 ` Felipe Balbi
@ 2021-09-24 10:28 ` Felipe Balbi
0 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2021-09-24 10:28 UTC (permalink / raw)
To: Zhiwei Yang; +Cc: Greg Kroah-Hartman, linux-usb
Hi,
Felipe Balbi <balbi@kernel.org> writes:
> Zhiwei Yang <yangzhiwei@uniontech.com> writes:
>
>> Remove the debug info which should be instead with ftrace
>
> why?
>
>> Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
>> ---
>> drivers/usb/phy/phy-tahvo.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
>> index 5dc600fadc5f..468151496d23 100644
>> --- a/drivers/usb/phy/phy-tahvo.c
>> +++ b/drivers/usb/phy/phy-tahvo.c
>> @@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host)
>> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
>> phy);
>>
>> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
>> -
>> mutex_lock(&tu->serialize);
>>
>> if (host == NULL) {
>> @@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
>> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb,
>> phy);
>>
>> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
>
> is this causing any problems? What sort of problems? Why should we take
> this patch?
nevermind, I saw that your original patch was simply replacing %p with
%pK but Greg asked you to just remove the lines.
Thank you.
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-24 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-24 8:38 [PATCH] USB: phy: tahvo:remove unnecessary debug log Zhiwei Yang
2021-09-24 10:04 ` Sergey Shtylyov
2021-09-24 10:23 ` Felipe Balbi
2021-09-24 10:28 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox