linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, pawell@cadence.com,
	rogerq@ti.com, gregkh@linuxfoundation.org, jun.li@nxp.com,
	Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH v2 1/8] usb: cdns3: gadget: using correct sg operations
Date: Thu, 24 Sep 2020 10:27:13 +0300	[thread overview]
Message-ID: <87ft77eisu.fsf@kernel.org> (raw)
In-Reply-To: <20200910091130.20937-2-peter.chen@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Peter Chen <peter.chen@nxp.com> writes:

> It needs to use request->num_mapped_sgs to indicate mapped sg number,
> the request->num_sgs is the sg number before the mapping. These two
> entries have different values for the platforms which iommu or
> swiotlb is used. Besides, it needs to use correct sg APIs for
> mapped sg list for TRB assignment.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>

fails to apply to my testing/next

checking file drivers/usb/cdns3/gadget.c
Hunk #1 succeeded at 1099 (offset 1 line).
Hunk #2 succeeded at 1165 (offset 1 line).
Hunk #3 FAILED at 1176.
Hunk #4 succeeded at 1221 with fuzz 2 (offset 1 line).
1 out of 4 hunks FAILED

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2020-09-24  7:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  9:11 [PATCH v2 0/8] usb: cdns3: improve the sg use case Peter Chen
2020-09-10  9:11 ` [PATCH v2 1/8] usb: cdns3: gadget: using correct sg operations Peter Chen
2020-09-24  7:27   ` Felipe Balbi [this message]
2020-09-24  9:33     ` Peter Chen
2020-09-29  3:40       ` Peter Chen
2020-09-29  6:29         ` Felipe Balbi
2020-09-10  9:11 ` [PATCH v2 2/8] usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer Peter Chen
2020-09-10  9:11 ` [PATCH v2 3/8] usb: cdns3: gadget: calculate TDL correctly Peter Chen
2020-09-10  9:11 ` [PATCH v2 4/8] usb: cdns3: gadget: add CHAIN and ISP bit for sg list use case Peter Chen
2020-09-10  9:11 ` [PATCH v2 5/8] usb: cdns3: gadget: handle sg list use case at completion correctly Peter Chen
2020-09-10  9:11 ` [PATCH v2 6/8] usb: cdns3: gadget: need to handle sg case for workaround 2 case Peter Chen
2020-09-10  9:11 ` [PATCH v2 7/8] usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above Peter Chen
2020-09-10  9:11 ` [PATCH v2 8/8] usb: cdns3: gadget: enlarge the TRB ring length Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft77eisu.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    --cc=peter.chen@nxp.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).