From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux@roeck-us.net, kernel@collabora.com
Subject: Re: [PATCH] usb: hub: Guard against accesses to uninitialized BOS descriptors
Date: Wed, 30 Aug 2023 12:56:37 +0200 [thread overview]
Message-ID: <87h6oghk7u.fsf@collabora.com> (raw)
In-Reply-To: <2023083007-vowed-latitude-acef@gregkh>
Hi Greg, thanks for reviewing.
On mié, ago 30 2023 at 12:13:44, Greg KH <gregkh@linuxfoundation.org> wrote:
> Did you mean to loose the indentation here?
This output has probably gone through some processing before I got it,
so that's likely the cause. I don't have access to the original output,
sorry. If I need to fix something for a v2 I can try to re-format it to
add the indentation back in.
> What commit id does this fix?
This isn't linked to a particular single commit, it fixes the same
problem in different parts of the code, introduced by different commits
over time. The starting point for the fix was the crash output in the
commit message but, for additional context, these are the original
commits that introduced the unguarded struct accesses:
0cdd49a1d1a4 ("usb: Support USB 3.1 extended port status request")
51e0a0120661 ("USB: Calculate USB 3.0 exit latencies for LPM.")
25cd2882e2fc ("usb/xhci: Change how we indicate a host supports Link PM.")
0299809be415 ("usb: core: Track SuperSpeed Plus GenXxY")
ae8963adb4ad ("usb: Don't enable LPM if the exit latency is zero.")
Cheers,
Ricardo
next prev parent reply other threads:[~2023-08-30 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 10:04 [PATCH] usb: hub: Guard against accesses to uninitialized BOS descriptors Ricardo Cañuelo
2023-08-30 10:13 ` Greg KH
2023-08-30 10:56 ` Ricardo Cañuelo [this message]
2023-08-30 11:01 ` Ricardo Cañuelo
2023-08-30 11:12 ` Greg KH
2023-09-22 5:40 ` Ricardo Cañuelo
2023-09-22 9:12 ` Greg KH
2023-09-22 9:38 ` Ricardo Cañuelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6oghk7u.fsf@collabora.com \
--to=ricardo.canuelo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).