From: Felipe Balbi <balbi@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg KH <greg@kroah.com>
Cc: "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: Aspeed vhub configuration
Date: Wed, 03 Jul 2019 09:24:06 +0300 [thread overview]
Message-ID: <87h883d4ah.fsf@linux.intel.com> (raw)
In-Reply-To: <3cea94e3f461c44c0799c2d494b174d20895cc08.camel@kernel.crashing.org>
Hi,
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Tue, 2019-07-02 at 15:56 +0300, Felipe Balbi wrote:
>> We already have an interface for disconnecting from the host
>> programatically by disconnecting data pullup.
>>
>> static ssize_t soft_connect_store(struct device *dev,
>> struct device_attribute *attr, const char *buf,
>> size_t n)
>
> .../...
>
> I could reproduce the same interface for the vhub, at least it would
> provide consistency...
>
> The vhub itself is not an UDC device. It provides UDC devices that are
> the hub "ports".
Right, if you have your UDC devices and you implement ->udc_start(),
->udc_stop() and ->pullup(), you *already* have this interface for you.
--
balbi
next prev parent reply other threads:[~2019-07-03 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 11:33 Aspeed vhub configuration Benjamin Herrenschmidt
2019-07-02 12:24 ` Greg KH
2019-07-02 12:29 ` Benjamin Herrenschmidt
2019-07-02 12:56 ` Felipe Balbi
2019-07-02 13:10 ` Benjamin Herrenschmidt
2019-07-03 6:24 ` Felipe Balbi [this message]
2019-07-03 22:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h883d4ah.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).