From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382CDC5B578 for ; Wed, 3 Jul 2019 06:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 067032187F for ; Wed, 3 Jul 2019 06:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562135050; bh=yIqwqxz253M0YxDcgvi+cwCFAvdESkGL0AdEu7aJX98=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=eO0XonN5epRLWLR9XoUHSh4T4Tg6IDgc427gi+GblE9F2Bd8Lz0iyKsA11dRBup1o g05vQ8X8X6qut1utdtp9/pPmA3X+lDeDU2n7ddxuQluB20sg3uQEkiQ2t00gZzWcOo I3FAhUg7RcbFVQys8E9omvkIz0omPUQk2faU3QrM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726236AbfGCGYJ (ORCPT ); Wed, 3 Jul 2019 02:24:09 -0400 Received: from mga07.intel.com ([134.134.136.100]:54499 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbfGCGYJ (ORCPT ); Wed, 3 Jul 2019 02:24:09 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 23:24:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="362928867" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by fmsmga006.fm.intel.com with ESMTP; 02 Jul 2019 23:24:07 -0700 From: Felipe Balbi To: Benjamin Herrenschmidt , Greg KH Cc: "linux-usb\@vger.kernel.org" Subject: Re: Aspeed vhub configuration In-Reply-To: <3cea94e3f461c44c0799c2d494b174d20895cc08.camel@kernel.crashing.org> References: <44bb150fb8b283a3036a382fa7e821b045554c15.camel@kernel.crashing.org> <20190702122430.GC12019@kroah.com> <8736jobnnb.fsf@linux.intel.com> <3cea94e3f461c44c0799c2d494b174d20895cc08.camel@kernel.crashing.org> Date: Wed, 03 Jul 2019 09:24:06 +0300 Message-ID: <87h883d4ah.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Benjamin Herrenschmidt writes: > On Tue, 2019-07-02 at 15:56 +0300, Felipe Balbi wrote: >> We already have an interface for disconnecting from the host >> programatically by disconnecting data pullup. >> >> static ssize_t soft_connect_store(struct device *dev, >> struct device_attribute *attr, const char *buf, >> size_t n) > > .../... > > I could reproduce the same interface for the vhub, at least it would > provide consistency... > > The vhub itself is not an UDC device. It provides UDC devices that are > the hub "ports". Right, if you have your UDC devices and you implement ->udc_start(), ->udc_stop() and ->pullup(), you *already* have this interface for you. -- balbi