From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1081E3DA7E6 for ; Thu, 2 Apr 2026 18:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775155232; cv=none; b=O8Y5GGolmKiDLMw0LDj474tDmTMhAWFz2jVK2aZtBhLLIZhZxasdlRdPGImark+yqsEjGq7ZqV9xJg76xIFiEPVLYvvZZIjvvZk+b85cSq03ruHDqWhf6nl7KTfQ+yz5wS5WHW0E5hqGnzf6B7HgWqrTA6RB63hxfGjJHqtQZI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775155232; c=relaxed/simple; bh=IGOTpnOWDhUNR6ygSwu6UiYoWIqzwIeSdtLHU/RSj5Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WDHoLs5J4Z+7Ctolr1/3YZjZ333gZ4Y5wkN93Xwu1kqPxWg/OBuojpXlZqqDD9C5ybVnS7hBPVNeouoIsXOTq8sWjSwf9G+KNviZNlqktO1yk95r3XKAN5NVAmXN9i6dGsq1CvadRN/ygV3NiyLWoIPAMt6uTNdlsDk+j/VlACE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com; spf=pass smtp.mailfrom=korsgaard.com; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b=jYz2k6Jh; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b="jYz2k6Jh" DKIM-Signature: a=rsa-sha256; b=jYz2k6Jhz90VpxqcfzwfdqjH6zXHh6OD+OGVIGWOwhsJE6ycqBoBlP5H9XXij7fbwPClse+jjLECJNA69GHK7NUltHHOLernjKaCvRDIGdfrT7x/DwTfCqeC7haEIUtB8ZlW3cO0bnTZVTW+8oA3bK2Y9GLh6QUK+Rz6NNFF6jvzJHayNoqHrz9aTFcOOI7wARfMN3k7JDfugDQ72KIiCoTMjf7/73iQsMYENvGWc0avzijuEtk//zvQYkhvgdUwPZK4kncHc3sIW1hvKquUiD1suj0tFA3pUGRIKk+dkvro71EE6F3SHlBrpNtsPJviDKQZMxQ35Hg/6LTY9nIVRQ==; s=purelymail2; d=purelymail.com; v=1; bh=IGOTpnOWDhUNR6ygSwu6UiYoWIqzwIeSdtLHU/RSj5Q=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 21632:4007:null:purelymail X-Pm-Original-To: linux-usb@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -681438166; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 02 Apr 2026 18:40:05 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.98.2) (envelope-from ) id 1w8MxX-00000006w84-1qq1; Thu, 02 Apr 2026 20:40:03 +0200 From: Peter Korsgaard To: Ethan Tidmore Cc: gregkh@linuxfoundation.org, sigmaepsilon92@gmail.com, mhklinux@outlook.com, linuxhid@cosmicgizmosystems.com, danisjiang@gmail.com, kees@kernel.org, hoff.benjamin.k@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_hid: Add missing error code In-Reply-To: <20260402180008.64233-1-ethantidmore06@gmail.com> (Ethan Tidmore's message of "Thu, 2 Apr 2026 13:00:08 -0500") References: <20260402180008.64233-1-ethantidmore06@gmail.com> Date: Thu, 02 Apr 2026 20:40:03 +0200 Message-ID: <87ika95hq4.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain >>>>> "Ethan" == Ethan Tidmore writes: > Currently in cdev_alloc() error path no error code is assigned. > Assign error code '-ENOMEM'. > Detected by Smatch: > drivers/usb/gadget/function/f_hid.c:1291 hidg_bind() > warn: missing error code 'status' > Fixes: 81ebd43cc0d6d ("usb: gadget: f_hid: don't call cdev_init while cdev in use") > Signed-off-by: Ethan Tidmore Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard