From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH v3 2/4] usb: dwc3: gadget: Account for extra TRB
Date: Mon, 07 Sep 2020 09:28:26 +0300 [thread overview]
Message-ID: <87imcq14ol.fsf@kernel.org> (raw)
In-Reply-To: <3a914ab743485860aeffeb55d46b312491d7d811.1599098161.git.thinhn@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi,
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> When checking for how many TRB remaining, make sure to account for extra
> TRBs for ZLP or MPS alignment transfers. Since the dwc3_prepare_trb*
> functions should know if we need the extra TRBs, make those functions
> return a status code -EAGAIN if there isn't enough TRB. Check against
> those status when preparing TRB instead.
>
> Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
this is quite extensive for a fix and it also depends on the previous
refactoring from what I can tell. In that case, you can break this down
into smaller patches.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-09-07 6:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 2:06 [PATCH v3 0/4] usb: dwc3: gadget: Fix TRB preparation Thinh Nguyen
2020-09-03 2:06 ` [PATCH v3 1/4] usb: dwc3: gadget: Refactor preparing TRBs Thinh Nguyen
2020-09-07 6:24 ` Felipe Balbi
2020-09-08 18:17 ` Thinh Nguyen
2020-09-03 2:06 ` [PATCH v3 2/4] usb: dwc3: gadget: Account for extra TRB Thinh Nguyen
2020-09-07 6:28 ` Felipe Balbi [this message]
2020-09-08 18:21 ` Thinh Nguyen
2020-09-03 2:06 ` [PATCH v3 3/4] usb: dwc3: gadget: Rename misleading function names Thinh Nguyen
2020-09-03 2:06 ` [PATCH v3 4/4] usb: dwc3: ep0: Skip ZLP setup for OUT Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imcq14ol.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).