[PATCH v2 1/2] usb: dwc3: Add ACPI support for xHCI ports

[PATCH v2 1/2] usb: dwc3: Add ACPI support for xHCI ports

[Andy Shevchenko]

The ACPI companion of the adapter has to be set for xHCI controller
code to read and attach the ports described in the ACPI table.
Use ACPI_COMPANION_SET macro to set this.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: split out kernel doc fix
 drivers/usb/dwc3/host.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index fa252870c926..95a90ea08975 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -7,6 +7,7 @@
  * Authors: Felipe Balbi <balbi@ti.com>,
  */
 
+#include <linux/acpi.h>
 #include <linux/platform_device.h>
 
 #include "core.h"
@@ -75,6 +76,7 @@ int dwc3_host_init(struct dwc3 *dwc)
 	}
 
 	xhci->dev.parent	= dwc->dev;
+	ACPI_COMPANION_SET(&xhci->dev, ACPI_COMPANION(dwc->dev));
 
 	dwc->xhci = xhci;
 
-- 
2.25.0

[PATCH v2 2/2] usb: dwc3: Remove kernel doc annotation where it's not needed

[Andy Shevchenko]

The main comment in the file mistakenly marked with kernel doc annotation
which makes the parser unhappy:

.../dwc3/host.c:16: warning: Function parameter or member 'dwc' not described in 'dwc3_host_get_irq'

Drop kernel doc annotation from host.c module.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: new patch (Felipe)
 drivers/usb/dwc3/host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index 95a90ea08975..86dbd012b984 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/**
+/*
  * host.c - DesignWare USB3 DRD Controller Host Glue
  *
  * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com
-- 
2.25.0

Re: [PATCH v2 1/2] usb: dwc3: Add ACPI support for xHCI ports

[Andy Shevchenko]

On Tue, Feb 18, 2020 at 05:12:18PM +0200, Andy Shevchenko wrote:
> The ACPI companion of the adapter has to be set for xHCI controller
> code to read and attach the ports described in the ACPI table.
> Use ACPI_COMPANION_SET macro to set this.

Felipe, do you have any comments on this?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: split out kernel doc fix
>  drivers/usb/dwc3/host.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index fa252870c926..95a90ea08975 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -7,6 +7,7 @@
>   * Authors: Felipe Balbi <balbi@ti.com>,
>   */
>  
> +#include <linux/acpi.h>
>  #include <linux/platform_device.h>
>  
>  #include "core.h"
> @@ -75,6 +76,7 @@ int dwc3_host_init(struct dwc3 *dwc)
>  	}
>  
>  	xhci->dev.parent	= dwc->dev;
> +	ACPI_COMPANION_SET(&xhci->dev, ACPI_COMPANION(dwc->dev));
>  
>  	dwc->xhci = xhci;
>  
> -- 
> 2.25.0
> 

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 1/2] usb: dwc3: Add ACPI support for xHCI ports

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> On Tue, Feb 18, 2020 at 05:12:18PM +0200, Andy Shevchenko wrote:
>> The ACPI companion of the adapter has to be set for xHCI controller
>> code to read and attach the ports described in the ACPI table.
>> Use ACPI_COMPANION_SET macro to set this.
>
> Felipe, do you have any comments on this?

applied

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]