From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: vigneshr@ti.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-stable # = v4 . 13" <stable@vger.kernel.org>
Subject: usb: dwc3: core: Don't try to get PHYs during suspend/resume
Date: Thu, 11 Jan 2018 10:25:35 +0200 [thread overview]
Message-ID: <87inc8yf7k.fsf@linux.intel.com> (raw)
Hi,
Roger Quadros <rogerq@ti.com> writes:
>>>> - ret = dwc3_core_soft_reset(dwc);
>>>> + ret = dwc3_core_get_phy(dwc);
>>>
>>> we can get_phy in dwc3_core_init() as it will get called on resume().
>>> This was the $subject of this patch.
>>
>> indeed. thanks :-)
>>
>
> oops sorry. I meant we can't call dwc3_core_get_phy() in dwc3_core_init(). :P
bit of a chicken-and-egg problem. We need to setup the PHY interface
before getting the PHYs, but can't get PHY during resume. Maybe the best
way here would be to check for the pointers being valid. Something like:
if (!phy)
get_phy();
next reply other threads:[~2018-01-11 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:25 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-11 9:46 usb: dwc3: core: Don't try to get PHYs during suspend/resume Roger Quadros
2018-01-11 9:31 Felipe Balbi
2018-01-11 9:23 Roger Quadros
2018-01-11 9:09 Roger Quadros
2018-01-10 14:13 Roger Quadros
2018-01-10 14:04 Felipe Balbi
2018-01-10 13:56 Roger Quadros
2018-01-10 13:33 Felipe Balbi
2018-01-10 13:24 Roger Quadros
2018-01-10 13:11 Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inc8yf7k.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).