From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20ADC433B4 for ; Fri, 14 May 2021 07:25:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C99561446 for ; Fri, 14 May 2021 07:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232381AbhENH0L (ORCPT ); Fri, 14 May 2021 03:26:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:55586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbhENH0L (ORCPT ); Fri, 14 May 2021 03:26:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A436561446; Fri, 14 May 2021 07:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620977100; bh=15ezUcoX2Tp5onmLNEbYjA7IRAW1s32VZAsjPbUMDow=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZygTqMk0DJgrTsghfeYNhwDq/A2Re2zuZq73koYZX9dSAxSTJGNGMewoHynPWP9OK tyjXLV8feLl1cQW7K51qvI9gaDAbyNLf9fsuTC8GWNcUmQAcQNrYeRo3LvWOKusKfC u+dFSPgr6AQVUmiLbYGM5XiFxmqTNDSdHardsgZLnDDWVwRHUbfFSYWUhozMLl3NWu xKWI0tvuk0bqyn1cax0UPNkX8M479xy960BvU8QwGFa+tjs5+SITjval+q4fvNUGs2 g5WWMQ1p6q+srbokCw8B3UuBQAfG2MFcaSnOX3XyFlgQHZY2zzs/48wy52snIqq3QT g24j/t25VVGDQ== From: Felipe Balbi To: "Gustavo A. R. Silva" , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] usb: gadget: s3c-hsudc: Use struct_size() in devm_kzalloc() In-Reply-To: <20210513193353.GA196565@embeddedor> References: <20210513193353.GA196565@embeddedor> Date: Fri, 14 May 2021 10:24:50 +0300 Message-ID: <87k0o17p6l.fsf@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable "Gustavo A. R. Silva" writes: > Make use of the struct_size() helper instead of an open-coded version, > in order to avoid any potential type mistakes or integer overflows > that, in the worse scenario, could lead to heap overflows. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFFBAEBCAAvFiEE9DumQ60WEZ09LIErzlfNM9wDzUgFAmCeJcIRHGJhbGJpQGtl cm5lbC5vcmcACgkQzlfNM9wDzUh9UQgAoHsTFS64PtkTiiLe9txwadAGZu1jUqWd rifBnWCjW0qkcPu6k74kykvO743iZ8S1NBFifgaARaSmiPvH3v6hIYbiN+co+QWR dvkErw3FeTn5FqhAJdamv4nXcRecdmiutseGRUBExLA+vjbDKrCAp+3MNzf9emws cTyBJaRgp0GCshhHyGKzvxRLRDt3USNBvN67vIxJMNgC0C2gg1D8Kp6qok5PzJCq ppiCSPMw6ytSbKUGh5XBATPcgxE64jRoFFNObtPxByKlmvqTKC6rYQ0I9y48un+c /Lo/5hc2yiepHWuwx6LE+LSSCkoFDQnhZt28yDELxP7Tl0bXqDnK3g== =3cIq -----END PGP SIGNATURE----- --=-=-=--