From: Felipe Balbi <balbi@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse
Date: Thu, 23 Jul 2020 14:40:41 +0300 [thread overview]
Message-ID: <87k0yuo3wm.fsf@kernel.org> (raw)
In-Reply-To: <20200702072914.1072878-1-gregkh@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> This file has a HUGE debugging sysfs file that spews out a lot of
> information all at once, which violates the one-value-per-file rule for
> sysfs. If this is really needed, it should go into debugfs, but given
> the age of this driver, I strongly doubt anyone is using it anymore.
>
> So just remove the file entirely, it was never documented, so obviously,
> no one actually needed it :)
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
applied both, thanks Greg.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-07-23 11:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 7:29 [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse Greg Kroah-Hartman
2020-07-02 7:29 ` [PATCH 2/2] USB: phy: fsl-usb: remove character device usage Greg Kroah-Hartman
2020-07-02 9:07 ` Peter Chen
2020-07-02 10:33 ` Greg Kroah-Hartman
2020-07-03 1:56 ` Ran Wang
2020-07-03 7:02 ` Greg Kroah-Hartman
2020-07-02 9:07 ` [PATCH 1/2] USB: phy: fsl-usb: remove sysfs abuse Peter Chen
2020-07-03 1:49 ` Ran Wang
2020-07-23 11:40 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0yuo3wm.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).