From: Felipe Balbi <balbi@kernel.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, Raymond Tan <raymond.tan@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality
Date: Thu, 24 Sep 2020 10:24:40 +0300 [thread overview]
Message-ID: <87lfgzeix3.fsf@kernel.org> (raw)
In-Reply-To: <20200914121425.GA810499@kuha.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]
Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:
> Hi Felipe,
>
> On Fri, Aug 21, 2020 at 04:11:01PM +0300, Heikki Krogerus wrote:
>> From: Raymond Tan <raymond.tan@intel.com>
>>
>> Similar to some other IA platforms, Elkhart Lake too depends on the
>> PMU register write to request transition of Dx power state.
>>
>> Thus, we add the PCI_DEVICE_ID_INTEL_EHLLP to the list of devices that
>> shall execute the ACPI _DSM method during D0/D3 sequence.
>>a
>> [heikki.krogerus@linux.intel.com: included Fixes tag]
>>
>> Fixes: dbb0569de852 ("usb: dwc3: pci: Add Support for Intel Elkhart Lake Devices")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Raymond Tan <raymond.tan@intel.com>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> ---
>> drivers/usb/dwc3/dwc3-pci.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
>> index f5a61f57c74f0..242b6210380a4 100644
>> --- a/drivers/usb/dwc3/dwc3-pci.c
>> +++ b/drivers/usb/dwc3/dwc3-pci.c
>> @@ -147,7 +147,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
>>
>> if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
>> if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
>> - pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
>> + pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
>> + pdev->device == PCI_DEVICE_ID_INTEL_EHLLP) {
>> guid_parse(PCI_INTEL_BXT_DSM_GUID, &dwc->guid);
>> dwc->has_dsm_for_pm = true;
>> }
>
> I think this has gone under your radar. Let me know if you want
> anything to be changed.
Applied
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
prev parent reply other threads:[~2020-09-24 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 13:11 [PATCH] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality Heikki Krogerus
2020-09-14 12:14 ` Heikki Krogerus
2020-09-24 7:24 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfgzeix3.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=raymond.tan@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).