[PATCH] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality

[PATCH] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality

[Heikki Krogerus]

From: Raymond Tan <raymond.tan@intel.com>

Similar to some other IA platforms, Elkhart Lake too depends on the
PMU register write to request transition of Dx power state.

Thus, we add the PCI_DEVICE_ID_INTEL_EHLLP to the list of devices that
shall execute the ACPI _DSM method during D0/D3 sequence.

[heikki.krogerus@linux.intel.com: included Fixes tag]

Fixes: dbb0569de852 ("usb: dwc3: pci: Add Support for Intel Elkhart Lake Devices")
Cc: stable@vger.kernel.org
Signed-off-by: Raymond Tan <raymond.tan@intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/usb/dwc3/dwc3-pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index f5a61f57c74f0..242b6210380a4 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -147,7 +147,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
 
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
 		if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
-				pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
+		    pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
+		    pdev->device == PCI_DEVICE_ID_INTEL_EHLLP) {
 			guid_parse(PCI_INTEL_BXT_DSM_GUID, &dwc->guid);
 			dwc->has_dsm_for_pm = true;
 		}
-- 
2.28.0

Re: [PATCH] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality

[Heikki Krogerus]

Hi Felipe,

On Fri, Aug 21, 2020 at 04:11:01PM +0300, Heikki Krogerus wrote:
> From: Raymond Tan <raymond.tan@intel.com>
> 
> Similar to some other IA platforms, Elkhart Lake too depends on the
> PMU register write to request transition of Dx power state.
> 
> Thus, we add the PCI_DEVICE_ID_INTEL_EHLLP to the list of devices that
> shall execute the ACPI _DSM method during D0/D3 sequence.
>a 
> [heikki.krogerus@linux.intel.com: included Fixes tag]
> 
> Fixes: dbb0569de852 ("usb: dwc3: pci: Add Support for Intel Elkhart Lake Devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Raymond Tan <raymond.tan@intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/usb/dwc3/dwc3-pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index f5a61f57c74f0..242b6210380a4 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -147,7 +147,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
>  
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
>  		if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
> -				pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
> +		    pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
> +		    pdev->device == PCI_DEVICE_ID_INTEL_EHLLP) {
>  			guid_parse(PCI_INTEL_BXT_DSM_GUID, &dwc->guid);
>  			dwc->has_dsm_for_pm = true;
>  		}

I think this has gone under your radar. Let me know if you want
anything to be changed.

thanks,

-- 
heikki

Re: [PATCH] usb: dwc3: pci: Allow Elkhart Lake to utilize DSM method for PM functionality

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:

> Hi Felipe,
>
> On Fri, Aug 21, 2020 at 04:11:01PM +0300, Heikki Krogerus wrote:
>> From: Raymond Tan <raymond.tan@intel.com>
>> 
>> Similar to some other IA platforms, Elkhart Lake too depends on the
>> PMU register write to request transition of Dx power state.
>> 
>> Thus, we add the PCI_DEVICE_ID_INTEL_EHLLP to the list of devices that
>> shall execute the ACPI _DSM method during D0/D3 sequence.
>>a 
>> [heikki.krogerus@linux.intel.com: included Fixes tag]
>> 
>> Fixes: dbb0569de852 ("usb: dwc3: pci: Add Support for Intel Elkhart Lake Devices")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Raymond Tan <raymond.tan@intel.com>
>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> ---
>>  drivers/usb/dwc3/dwc3-pci.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
>> index f5a61f57c74f0..242b6210380a4 100644
>> --- a/drivers/usb/dwc3/dwc3-pci.c
>> +++ b/drivers/usb/dwc3/dwc3-pci.c
>> @@ -147,7 +147,8 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)
>>  
>>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
>>  		if (pdev->device == PCI_DEVICE_ID_INTEL_BXT ||
>> -				pdev->device == PCI_DEVICE_ID_INTEL_BXT_M) {
>> +		    pdev->device == PCI_DEVICE_ID_INTEL_BXT_M ||
>> +		    pdev->device == PCI_DEVICE_ID_INTEL_EHLLP) {
>>  			guid_parse(PCI_INTEL_BXT_DSM_GUID, &dwc->guid);
>>  			dwc->has_dsm_for_pm = true;
>>  		}
>
> I think this has gone under your radar. Let me know if you want
> anything to be changed.

Applied

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]