From: Baruch Siach <baruch@tkos.co.il>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Jun Li <jun.li@nxp.com>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v2] usb: dwc3: move core validation to be after clks enable
Date: Fri, 24 May 2019 05:57:12 +0300 [thread overview]
Message-ID: <87lfyw36gn.fsf@tarshish> (raw)
In-Reply-To: <30102591E157244384E984126FC3CB4F639FFEE3@us01wembx1.internal.synopsys.com>
Hi Thinh,
On Fri, May 24 2019, Thinh Nguyen wrote:
> Baruch Siach wrote:
>> Hi Jun Li,
>>
>> On Wed, May 08, 2019 at 10:52:37AM +0000, Jun Li wrote:
>>> From: Jun Li <jun.li@nxp.com>
>>>
>>> Register access in core validation may hang before the bulk
>>> clks are enabled.
>> This patch fixes the hang issue for on my i.MX8MQ based system.
>>
>> Tested-by: Baruch Siach <baruch@tkos.co.il>
>>
>> However, commit b873e2d0ea1e is meant to move dwc3_core_is_valid() before
>> dwc3_get_dr_mode(). With this patch dwc3_get_dr_mode() is called from
>> dwc3_get_properties() before dwc3_core_is_valid().
>>
>> I guess we need a larger change in the initialization sequence.
>>
>> Thanks,
>> baruch
>
> Look again. dwc3_get_dr_mode() is not called from dwc3_get_properties().
>
> This patch is fine.
Your are right. The usb_get_dr_mode() call confused me.
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2019-05-24 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 10:52 [PATCH v2] usb: dwc3: move core validation to be after clks enable Jun Li
2019-05-23 15:15 ` Baruch Siach
2019-05-23 22:31 ` Thinh Nguyen
2019-05-24 2:57 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfyw36gn.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).