* usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing
@ 2019-01-14 8:57 Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2019-01-14 8:57 UTC (permalink / raw)
To: Minas Harutyunyan; +Cc: John Youn
Hi,
Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
>>>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>>>> index 68ad75a7460d..55ef3cc2701b 100644
>>>> --- a/drivers/usb/dwc2/gadget.c
>>>> +++ b/drivers/usb/dwc2/gadget.c
>>>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>>>>
>>>> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
>>>> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
>>>> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>>>> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>>>> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
>>>> }
>>>> }
>>>>
>>>
>>> Sorry for last minute fix of this stupid bug.
>>> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert
>>> interrupt handler."
>>
>> And where is that?
>>
> You mean where is "usb: dwc2: gadget: Fix WkupAlert interrupt handler."
> commit? If yes, then that commit id is
> d64bc8ee92856e39b3150d93e244ca8239ae6ada
oh, already upstream. Good. Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread* usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing
@ 2019-01-14 8:43 Minas Harutyunyan
0 siblings, 0 replies; 5+ messages in thread
From: Minas Harutyunyan @ 2019-01-14 8:43 UTC (permalink / raw)
To: Felipe Balbi, Minas Harutyunyan, Greg Kroah-Hartman,
linux-usb@vger.kernel.org
Cc: John Youn
Hi Filipe,
On 1/14/2019 12:15 PM, Felipe Balbi wrote:
>
> Hi,
>
> Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
>> Hi Greg, Filipe,
>>
>> On 12/12/2018 4:44 PM, Minas Harutyunyan wrote:
>>> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register
>>> require to write 1. This bit is implemented as "Write to clear".
>>>
>>> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert
>>> interrupt")
>>>
>>> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
>>> ---
>>> drivers/usb/dwc2/gadget.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>>> index 68ad75a7460d..55ef3cc2701b 100644
>>> --- a/drivers/usb/dwc2/gadget.c
>>> +++ b/drivers/usb/dwc2/gadget.c
>>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>>>
>>> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
>>> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
>>> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>>> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>>> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
>>> }
>>> }
>>>
>>
>> Sorry for last minute fix of this stupid bug.
>> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert
>> interrupt handler."
>
> And where is that?
>
You mean where is "usb: dwc2: gadget: Fix WkupAlert interrupt handler."
commit? If yes, then that commit id is
d64bc8ee92856e39b3150d93e244ca8239ae6ada
Thanks,
Minas
^ permalink raw reply [flat|nested] 5+ messages in thread* usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing
@ 2019-01-14 8:14 Felipe Balbi
0 siblings, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2019-01-14 8:14 UTC (permalink / raw)
To: Minas Harutyunyan, Greg Kroah-Hartman, linux-usb@vger.kernel.org
Cc: John Youn
Hi,
Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
> Hi Greg, Filipe,
>
> On 12/12/2018 4:44 PM, Minas Harutyunyan wrote:
>> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register
>> require to write 1. This bit is implemented as "Write to clear".
>>
>> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert
>> interrupt")
>>
>> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
>> ---
>> drivers/usb/dwc2/gadget.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
>> index 68ad75a7460d..55ef3cc2701b 100644
>> --- a/drivers/usb/dwc2/gadget.c
>> +++ b/drivers/usb/dwc2/gadget.c
>> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>>
>> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
>> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
>> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
>> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
>> }
>> }
>>
>
> Sorry for last minute fix of this stupid bug.
> Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert
> interrupt handler."
And where is that?
^ permalink raw reply [flat|nested] 5+ messages in thread* usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing
@ 2018-12-12 12:49 Minas Harutyunyan
0 siblings, 0 replies; 5+ messages in thread
From: Minas Harutyunyan @ 2018-12-12 12:49 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, linux-usb@vger.kernel.org; +Cc: John Youn
Hi Greg, Filipe,
On 12/12/2018 4:44 PM, Minas Harutyunyan wrote:
> To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register
> require to write 1. This bit is implemented as "Write to clear".
>
> Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert
> interrupt")
>
> Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 68ad75a7460d..55ef3cc2701b 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
>
> if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
> dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
> - dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
> + dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
> dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
> }
> }
>
Sorry for last minute fix of this stupid bug.
Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert
interrupt handler."
Thanks,
Minas
^ permalink raw reply [flat|nested] 5+ messages in thread* usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing
@ 2018-12-12 12:44 Minas Harutyunyan
0 siblings, 0 replies; 5+ messages in thread
From: Minas Harutyunyan @ 2018-12-12 12:44 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Minas Harutyunyan, linux-usb
Cc: John Youn, Grigor Tovmasyan
To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register
require to write 1. This bit is implemented as "Write to clear".
Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert
interrupt")
Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 68ad75a7460d..55ef3cc2701b 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
- dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
+ dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
}
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-14 8:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-14 8:57 usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2019-01-14 8:43 Minas Harutyunyan
2019-01-14 8:14 Felipe Balbi
2018-12-12 12:49 Minas Harutyunyan
2018-12-12 12:44 Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).