From: Felipe Balbi <balbi@kernel.org>
To: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc: Linux USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_uac2: fix AC Interface Header Descriptor wTotalLength
Date: Thu, 23 Jul 2020 14:36:43 +0300 [thread overview]
Message-ID: <87mu3qo438.fsf@kernel.org> (raw)
In-Reply-To: <CAB=otbT5x5qoPedo854b0e-+Tcw1+i7UsJ6kbBBQRPrSMMtsfA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
Ruslan Bilovol <ruslan.bilovol@gmail.com> writes:
> On Thu, Jul 9, 2020 at 9:38 AM Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Ruslan Bilovol <ruslan.bilovol@gmail.com> writes:
>>
>> > As per UAC2 spec (ch. 4.7.2), wTotalLength of AC Interface
>> > Header Descriptor "includes the combined length of this
>> > descriptor header and all Clock Source, Unit and Terminal
>> > descriptors."
>> >
>> > Thus add its size to its wTotalLength.
>> >
>> > Also after recent changes wTotalLength is calculated
>> > dynamically, update static definition of uac2_ac_header_descriptor
>> > accordingly
>> >
>> > Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
>>
>> Missing a Fixes tag here.
>
> The issue is present since this driver introduction in 2012 in the
> commit 132fcb460839 "usb: gadget: Add Audio Class 2.0 Driver",
> but in older version of the driver it should be fixed in the
> uac2_ac_header_descriptor structure initialization
>
> Should I resend this patch or you'll add this tag to the commit message
> by yourself:
> Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver")
added, thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-07-23 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 13:49 [PATCH] usb: gadget: f_uac2: fix AC Interface Header Descriptor wTotalLength Ruslan Bilovol
2020-07-09 6:38 ` Felipe Balbi
2020-07-09 12:07 ` Ruslan Bilovol
2020-07-23 11:36 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu3qo438.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).