From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D880C5517A for ; Wed, 11 Nov 2020 17:48:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D135020759 for ; Wed, 11 Nov 2020 17:48:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DQNFGQ2u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgKKRsF (ORCPT ); Wed, 11 Nov 2020 12:48:05 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:51342 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbgKKRsF (ORCPT ); Wed, 11 Nov 2020 12:48:05 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605116884; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=7g87NZ0M/XFTxCuaZCnkFZZOqSYBdmIg4bjJcPXl19M=; b=DQNFGQ2uYMU5hUw5eGuIwlMcCHismO4v8zDB8xGrymaS0sKBxT6VIRQDu0mTBzJOakI7wxeb RNKAlbvzP7cKqdO5RPdTqGtI9Kquz56tcoawQaqNUotmGgmRZy7I1o3CsBHmWqDkefaXhqa0 InC0Z6UVhS8Mx4sP5zyP0E+vm5A= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyIxZTE2YSIsICJsaW51eC11c2JAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5fac1b7f34c4908d19e68649 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 11 Nov 2020 17:12:31 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 12E90C433A1; Wed, 11 Nov 2020 17:12:30 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C6DEEC433C6; Wed, 11 Nov 2020 17:12:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C6DEEC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Heiner Kallweit Cc: Jakub Kicinski , David Miller , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B8rn?= Mork , Igor Mitsyanko , Sergey Matyukevich , Oliver Neukum , Peter Korsgaard , Steve Glendinning , Microchip Linux Driver Support , Jussi Kivilinna , "netdev\@vger.kernel.org" , linux-rdma@vger.kernel.org, Linux USB Mailing List , linux-wireless Subject: Re: [PATCH net-next 3/5] qtnfmac: switch to core handling of rx/tx byte/packet counters References: <5fbe3a1f-6625-eadc-b1c9-f76f78debb94@gmail.com> <4b22c155-6868-793f-ebfe-f797e16b9c40@gmail.com> Date: Wed, 11 Nov 2020 19:12:22 +0200 In-Reply-To: <4b22c155-6868-793f-ebfe-f797e16b9c40@gmail.com> (Heiner Kallweit's message of "Tue, 10 Nov 2020 20:48:54 +0100") Message-ID: <87o8k34y2x.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Heiner Kallweit writes: > Use netdev->tstats instead of a member of qtnf_vif for storing a pointer > to the per-cpu counters. This allows us to use core functionality for > statistics handling. > The driver sets netdev->needs_free_netdev, therefore freeing the per-cpu > counters at the right point in time is a little bit tricky. Best option > seems to be to use the ndo_init/ndo_uninit callbacks. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/wireless/quantenna/qtnfmac/core.c | 78 ++++--------------- > drivers/net/wireless/quantenna/qtnfmac/core.h | 4 - > .../quantenna/qtnfmac/pcie/pearl_pcie.c | 4 +- > .../quantenna/qtnfmac/pcie/topaz_pcie.c | 4 +- > 4 files changed, 20 insertions(+), 70 deletions(-) Jakub, feel free to take this to net-next: Acked-by: Kalle Valo But I can also take this to wireless-drivers-next, whichever you prefer. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches