From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>
Subject: Re: [PATCH 4/5] usb: dwc3: gadget: Handle transfer completion
Date: Thu, 14 May 2020 13:38:07 +0300 [thread overview]
Message-ID: <87o8qq4x9s.fsf@kernel.org> (raw)
In-Reply-To: <ad3a0e37-c611-c6e9-959b-7351fb82ed0a@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi,
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>> @@ -1223,6 +1231,10 @@ static void dwc3_prepare_trbs(struct dwc3_ep *dep)
>>>
>>> if (!dwc3_calc_trbs_left(dep))
>>> return;
>>> +
>>> + /* Don't prepare ahead. This is not an option for DWC_usb32. */
>>> + if (req->request.is_last)
>>> + return;
>> this requires some better description. Why isn't it an option for dwc_usb32?
>
> Internally, DWC_usb32 does some advance caching and burst that we should
> not prepare more TRB until the transfer is completed.
> This doesn't apply for isoc, missed a check here. Need to apply on the
> next version.
Do you mind re-wording this statement as a comment in the code?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-05-14 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 22:27 [PATCH 0/5] usb: dwc3: gadget: Handle streams Thinh Nguyen
2020-04-27 22:27 ` [PATCH 1/5] usb: gadget: Introduce usb_request->is_last field Thinh Nguyen
2020-04-29 3:15 ` Peter Chen
2020-04-30 1:00 ` Thinh Nguyen
2020-04-30 3:57 ` Peter Chen
2020-04-30 4:54 ` Thinh Nguyen
2020-04-30 14:21 ` Alan Stern
2020-04-30 17:17 ` Thinh Nguyen
2020-04-30 18:22 ` Alan Stern
2020-04-30 18:36 ` Thinh Nguyen
2020-04-27 22:27 ` [PATCH 2/5] usb: gadget: f_tcm: Inform last transfer request Thinh Nguyen
2020-04-27 22:27 ` [PATCH 3/5] usb: dwc3: gadget: Continue to process pending requests Thinh Nguyen
2020-04-27 22:27 ` [PATCH 4/5] usb: dwc3: gadget: Handle transfer completion Thinh Nguyen
2020-04-29 7:48 ` Felipe Balbi
2020-04-30 1:16 ` Thinh Nguyen
2020-05-14 10:38 ` Felipe Balbi [this message]
2020-05-15 1:23 ` Thinh Nguyen
2020-04-27 22:28 ` [PATCH 5/5] usb: dwc3: gadget: Handle stream transfers Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8qq4x9s.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).