From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C489303CBB for ; Thu, 6 Nov 2025 11:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762428567; cv=none; b=dOcWua9/weR1vrV/pj5sk+Jstk51Cjwv77Dl8ZYRMeOjm8fUtsLla4I3oQZDPP4kN/L7/ub+CGsbY/KD1xyFME8y9ZtsG+mxOBcEUgZTkzE6x9gEK5yN6HVhZqDR72FrQVD07eRcu7OoZAJJOwtF5IQtqC+SF5ZUS0LwEpfnByk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762428567; c=relaxed/simple; bh=WiXwaZ7wk2ejbRxQyW4OJIj/24cbdJjgusG6PUfSP3E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=BYlQ8jDVYbp65mMYtTNZtQ6oDCtDSkEdHtgBQyTTGCjOpJI3oC3FbYmgwMlHCoGCGJ+X8LxKQe/FIPFKEIYPhrYmsECcGDDGlGJKpvTO3gp44iPiXTR9QiZksyzKwaH/KnjYi1y1VE9V+6o/aVUIWTbWA+2I9tm3g9CdL1wAcr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f53txkOr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fADpZRzx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f53txkOr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fADpZRzx" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A65sE6c1738525 for ; Thu, 6 Nov 2025 11:29:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=CpG0B9NdSTpR4vRsiBshUT01 BMltg9VAt81WmjUMcSk=; b=f53txkOrNbj/o1C3+AlDeemTjSLBHjOtJTUw8CU5 /n5R1Ezk43jPqZvRRGhHXKBtWCcLlrjVs8rP91gefWrJHCZl1/z7RNZzxrSI8y2V FzTX/M5dWM9+uoCsLOcCnWk0L/gYiLyqnP+jruAuwdq8hXseVjEysTC0D0fCjm4F +FaP94X7tyjUKI5s3g+8E8G9D9Ym1kKQDwYJ4awGbm99RNzXeEkqFQB/RHXCG29j XxuDlTqc94Sa3DX8Sp8FRVtR1FoQarQ6f/R3LvePE912OmvxHc3c/6ZOOIkw8a0M MMymppl4rwbssT6t3tAW/WhgiBFv4v0b/xR4Qlgemhf7rQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a8an3tvxd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Nov 2025 11:29:25 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4eba1cea10dso8623761cf.1 for ; Thu, 06 Nov 2025 03:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762428564; x=1763033364; darn=vger.kernel.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=CpG0B9NdSTpR4vRsiBshUT01BMltg9VAt81WmjUMcSk=; b=fADpZRzxsjSBeNGfunJLcMHFyTI+LIw7nCgn6Nawyln8Ps13FIBuNLleGHLc5HVRpX XA0GrgBMtSoBweKcA6CcM3mNM2IgGyzDo1HfDOzYa3tVGgY/7Q/qv9hSN0FbD8E0Ay+J AFJleq7voNUWHlKc6O0V8Fz23g42YBv1aPrWVtZO+f2nca5U2+Qk2UI3O/8uVus4pQYr plGDgbr1NTQBqLauWUY6cHQun4TojMtUMhES2EbxJPVocRJE/St1A9IEHHwwQCsOYcD+ dFWZ3WJ4J15jxUDdgPA6BgW2Ante9P6BeEH/cd0JhXQUif4cj5lM4P06JO2WOX5eoR89 pMIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762428564; x=1763033364; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CpG0B9NdSTpR4vRsiBshUT01BMltg9VAt81WmjUMcSk=; b=M3nWVf2y53mZ2JWqfOHdmOcShs2LCir+y3lvYHFjq/MgoHS8pZGA51f9wabQF5B/U+ Z9uClPsjayMi2IM8CTJfKkrNhb2OtRqo1tRSPLcsVg2F2iYSgj9Br/t1wjaVoyLyJvdK wA0N+qx5ulOT1MV1UBYG5OzjrZpB7whrpZTqmWgj6VMhWnciLYfIX5XzAzatJmtJ7U5N Y10o0Syp4HQjBdQDTE8Cf6q2+OmlNJFeRKmdz8tjlp4GPFkM751OXFLjCxnr6lGCitJH dqeVG2Loh2zYIfykE7xjmCPtBWst1ZbmNp1PbNQERDfiyg+J5mRq2B9NNiY6dL43OE0+ WDJw== X-Forwarded-Encrypted: i=1; AJvYcCU+PnoN7BVoZZG+gQfvFX6vbee6X8ImUYyOfJhGc0vEYC7htTHFhqUx5Y3H0TUkXcRiKdMbqU3NbIc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1yXwhX93fsH1+2bgiIPb9O+g+QMUo2YQGMmzVqRqbzAB6O6HJ 3BWfeMx0E3U04vlpzqyVdE75jyrGL/wKrwwOwBLAl4lbRT0aq2mj2CEXDFZkaSXmk3zjbebmxd7 j4WAmTqSVVOq7TbpE42jE2PE9rHCwVNtBv4+r6VFQgO2gJjUm+s9E3VWhvduoCcvwmMADJhAq+F rc X-Gm-Gg: ASbGncvtkKGckEvYnzJdJwz4NcOsKi/SD5QQM5SP7tdG4Ag6pLyid2rlQj/e5xzx7uh WYQp5sAT2V/1v8ihud3diZWvtK2zzHnc6okABNy/dWU6MBG3GkJ8HTAUerFb95i7mHJlSbkJXaI He37+B7TfxkSswc1lNEZxgLa0ad6wr+si9hbjD01eHPh2LzDLMUtkhE9M4vlgNkOzrCJOBN7ciN C7MFDP0UnnChlXcRsjpEV3auoQ7PckgbSjcrh9qabhGjAp+QeS+1PrQFHnnLWxbC6uLD8A9KMuQ TkbCHh5hsxm1vq0WilTMV1xCepji4ZtI/Ip+G8zg5JmqOzUBqJHXw54QRJYjnq1KfiQ/Uz1Kecq M5L/5E9nNsscchA== X-Received: by 2002:a05:622a:420b:b0:4ed:4369:f3b0 with SMTP id d75a77b69052e-4ed726035eemr84625291cf.57.1762428564457; Thu, 06 Nov 2025 03:29:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHF5Y9MrAJi1CkAcyWCqIoql0rG+uICnIKE62F+OoH8UXgnjQwIAZmIHx1jJlThrKLOO7tPJA== X-Received: by 2002:a05:622a:420b:b0:4ed:4369:f3b0 with SMTP id d75a77b69052e-4ed726035eemr84625071cf.57.1762428563906; Thu, 06 Nov 2025 03:29:23 -0800 (PST) Received: from localhost ([2a01:4b00:b703:c200:1ac0:4dff:fe39:5426]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429eb4adde4sm4792649f8f.46.2025.11.06.03.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 03:29:23 -0800 (PST) From: Punit Agrawal To: Thinh Nguyen Cc: Punit Agrawal , "gregkh@linuxfoundation.org" , "fabioaiuto83@gmail.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jamie Iles Subject: Re: [PATCH] drivers/usb/dwc3: fix PCI parent check In-Reply-To: <20251106010123.mbtqd5epssrpbawv@synopsys.com> (Thinh Nguyen's message of "Thu, 6 Nov 2025 01:01:37 +0000") References: <20251105145801.485371-1-punit.agrawal@oss.qualcomm.com> <20251106010123.mbtqd5epssrpbawv@synopsys.com> Date: Thu, 06 Nov 2025 11:29:22 +0000 Message-ID: <87pl9v9z71.fsf@stealth> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Authority-Analysis: v=2.4 cv=W981lBWk c=1 sm=1 tr=0 ts=690c8695 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=jIQo8A4GAAAA:8 a=EUspDBNiAAAA:8 a=PokAWiqaKQyFClxnvusA:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: Hc6f6Icjr2hB3_dsZ_HirhX08umWabdK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA2MDA5MCBTYWx0ZWRfX3Yior7sRx09G snSSKIuXyS822FTSXCI0J9AZT19UHtfRJBE6+BamI9oEZWFgLai6R+oyOmdzWqjSDSfILKQjFHI SJxs/OxTzwdTrlNj5mRcG5COtkSTHgG+1E7d+EmG09VUAKf4l9+vR6hPwoKoF5g2c5aSDHmFIbv Sp5qYLteKhyiSEwO4HVc3rKoz+GDDnF86OUhy2dkcxGElN9eECTW9sZv/GpD9hSw+LmX8wTIXpH Be7s4J9rzDsfamJDGWUvH/fg6AIYPE2yyFuDOiTgNgmOJs7P1pcDBi+K9Iz/3yRnSRsPncgRnyi JR8aK1jY6frHIgJsc4vFqUC3sRZb/ppQt62YhCI06eunYckKXk3M4LXGL/L6VSD2+JcEdXfaWQx /Om3+PJJs+VeMz+bmE/ozppurVyQXA== X-Proofpoint-ORIG-GUID: Hc6f6Icjr2hB3_dsZ_HirhX08umWabdK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-06_03,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511060090 Thinh Nguyen writes: > On Wed, Nov 05, 2025, Punit Agrawal wrote: >> From: Jamie Iles >> >> The sysdev_is_parent check was being used to infer PCI devices that have >> the DMA mask set from the PCI capabilities, but sysdev_is_parent is also >> used for non-PCI ACPI devices in which case the DMA mask would be the >> bus default or as set by the _DMA method. >> >> Without this fix the DMA mask would default to 32-bits and so allocation >> would fail if there was no DRAM below 4GB. >> >> Fixes: 47ce45906ca9 ("usb: dwc3: leave default DMA for PCI devices") >> Signed-off-by: Jamie Iles >> Signed-off-by: Punit Agrawal > > We should Cc stable also. > >> --- >> drivers/usb/dwc3/core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> index ae140c356295..c2ce2f5e60a1 100644 >> --- a/drivers/usb/dwc3/core.c >> +++ b/drivers/usb/dwc3/core.c >> @@ -25,6 +25,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -2241,7 +2242,7 @@ int dwc3_core_probe(const struct dwc3_probe_data *data) >> dev_set_drvdata(dev, dwc); >> dwc3_cache_hwparams(dwc); >> >> - if (!dwc->sysdev_is_parent && >> + if (!dev_is_pci(dwc->sysdev) && >> DWC3_GHWPARAMS0_AWIDTH(dwc->hwparams.hwparams0) == 64) { >> ret = dma_set_mask_and_coherent(dwc->sysdev, DMA_BIT_MASK(64)); >> if (ret) >> -- >> 2.34.1 >> > > Acked-by: Thinh Nguyen Thank you for taking a look. Not sure if Greg prefers a repost or he can add the tag and Cc: stable while applying. I'll resend next week with updates if there's no response. [...]