From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org
Subject: [2/2] USB: gadget: pxa25x: Add DT probing
Date: Wed, 06 Feb 2019 22:31:41 +0100 [thread overview]
Message-ID: <87pns4txhe.fsf@belgarion.home> (raw)
Linus Walleij <linus.walleij@linaro.org> writes:
> This makes it possible to instantiate the PXA25x UDC
> driver from the device tree.
>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/usb/gadget/udc/pxa25x_udc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Mmmh it's a good start, but I don't think it's complete.
The kind of errors that bother me are lines such as :
> static int pxa25x_udc_probe(struct platform_device *pdev)
> ...
> if (gpio_is_valid(dev->mach->gpio_pullup)) {
I think this will be a NULL deref and kernel crash ...
From memory this driver relies on an always filled mach platform_data structure,
so the port to devicetree should be a bit more painful.
This makes me think that either :
- you have not run tested the patch
- or I'm late in the last patches and I'm missing some information
Cheers.
---
Robert
next reply other threads:[~2019-02-06 21:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 21:31 Robert Jarzmik [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-02 23:59 [2/2] USB: gadget: pxa25x: Add DT probing Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pns4txhe.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).