[12/15] usb: dwc3: Dump LSP and BMU debug info

[12/15] usb: dwc3: Dump LSP and BMU debug info

[Felipe Balbi]

Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> Dump LSP and BMU debug info.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>  drivers/usb/dwc3/core.h    | 5 +++++
>  drivers/usb/dwc3/debugfs.c | 5 +++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 83a74d10fa82..21a6dcd379f1 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -100,6 +100,11 @@
>  #define DWC3_GHWPARAMS7		0xc15c
>  #define DWC3_GDBGFIFOSPACE	0xc160
>  #define DWC3_GDBGLTSSM		0xc164
> +#define DWC3_GDBGBMU		0xc16c
> +#define DWC3_GDBGLSPMUX		0xc170
> +#define DWC3_GDBGLSP		0xc174
> +#define DWC3_GDBGEPINFO0	0xc178
> +#define DWC3_GDBGEPINFO1	0xc17c

wheren't these registers accessed with a write followed by a read? IIRC,
just writing them doesn't give us much information, no?

[12/15] usb: dwc3: Dump LSP and BMU debug info

[Thinh Nguyen]

Hi,

On 1/8/2018 4:08 AM, Felipe Balbi wrote:
> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> Dump LSP and BMU debug info.
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
>> ---
>>   drivers/usb/dwc3/core.h    | 5 +++++
>>   drivers/usb/dwc3/debugfs.c | 5 +++++
>>   2 files changed, 10 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index 83a74d10fa82..21a6dcd379f1 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -100,6 +100,11 @@
>>   #define DWC3_GHWPARAMS7		0xc15c
>>   #define DWC3_GDBGFIFOSPACE	0xc160
>>   #define DWC3_GDBGLTSSM		0xc164
>> +#define DWC3_GDBGBMU		0xc16c
>> +#define DWC3_GDBGLSPMUX		0xc170
>> +#define DWC3_GDBGLSP		0xc174
>> +#define DWC3_GDBGEPINFO0	0xc178
>> +#define DWC3_GDBGEPINFO1	0xc17c
> 
> wheren't these registers accessed with a write followed by a read? IIRC,
> just writing them doesn't give us much information, no?
> 

These registers are for internal use only. They hold the internal states 
that are useful for the HW engineers to debug. The databook doesn't 
specify that we need a write followed by a read to access these registers.

BR,
Thinh
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[12/15] usb: dwc3: Dump LSP and BMU debug info

[Thinh Nguyen]

Dump LSP and BMU debug info.

Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
 drivers/usb/dwc3/core.h    | 5 +++++
 drivers/usb/dwc3/debugfs.c | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 83a74d10fa82..21a6dcd379f1 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -100,6 +100,11 @@
 #define DWC3_GHWPARAMS7		0xc15c
 #define DWC3_GDBGFIFOSPACE	0xc160
 #define DWC3_GDBGLTSSM		0xc164
+#define DWC3_GDBGBMU		0xc16c
+#define DWC3_GDBGLSPMUX		0xc170
+#define DWC3_GDBGLSP		0xc174
+#define DWC3_GDBGEPINFO0	0xc178
+#define DWC3_GDBGEPINFO1	0xc17c
 #define DWC3_GPRTBIMAP_HS0	0xc180
 #define DWC3_GPRTBIMAP_HS1	0xc184
 #define DWC3_GPRTBIMAP_FS0	0xc188
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index 00e65530c81e..f09072395afe 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -81,6 +81,11 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GHWPARAMS7),
 	dump_register(GDBGFIFOSPACE),
 	dump_register(GDBGLTSSM),
+	dump_register(GDBGBMU),
+	dump_register(GDBGLSPMUX),
+	dump_register(GDBGLSP),
+	dump_register(GDBGEPINFO0),
+	dump_register(GDBGEPINFO1),
 	dump_register(GPRTBIMAP_HS0),
 	dump_register(GPRTBIMAP_HS1),
 	dump_register(GPRTBIMAP_FS0),