From: "Bjørn Mork" <bjorn@mork.no>
To: Johan Hovold <johan@kernel.org>
Cc: Romain Izard <romain.izard.pro@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>, Lars Melin <larsm17@gmail.com>
Subject: option: Do not try to bind to ADB interfaces
Date: Mon, 27 Aug 2018 18:15:52 +0200 [thread overview]
Message-ID: <87r2ijdbuv.fsf@miraculix.mork.no> (raw)
Johan Hovold <johan@kernel.org> writes:
> It would allow for simpler device-id entries, at least when ADB is the
> only blacklisted interface, and may enable ADB for some older entries.
>
> On the other hand, interface class 0xff is indeed supposed to be vendor
> specific as Lars and Greg pointed out, and with status quo we don't
> cause any regressions. If ADB isn't currently available for some device
> due to option binding to that interface, we'll just blacklist it as soon
> we get a report.
>
> So personally I'm not sure it's worth it, but I don't have a strong
> opinion on the matter either.
+1
The adb userspace application is also free to unbind any conflicting
driver, so I don't think blacklisting is strictly necessary. Except to
prevent any confusion caused by bogus ttyUSBx devices.
Bjørn
next reply other threads:[~2018-08-27 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 16:15 Bjørn Mork [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-29 7:56 option: Do not try to bind to ADB interfaces Johan Hovold
2018-08-27 13:28 Johan Hovold
2018-07-23 16:45 Romain Izard
2018-07-23 16:37 Romain Izard
2018-07-23 15:15 Lars Melin
2018-07-23 14:08 Greg Kroah-Hartman
2018-07-23 14:02 Romain Izard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ijdbuv.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).