Re: [PATCH v2 6/7] usb: dwc3: gadget: Rename misleading function names

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]


Hi,

Felipe Balbi <balbi@kernel.org> writes:

> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>
>> Hi Felipe,
>>
>> Felipe Balbi wrote:
>>> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>>
>>>> The functions dwc3_prepare_one_trb_sg and dwc3_prepare_one_trb_linear
>>>> are not necessarily preparing "one" TRB, it can prepare multiple TRBs.
>>>> Rename these functions as follow:
>>>>
>>>> dwc3_prepare_one_trb_sg -> dwc3_prepare_trbs_sg
>>>> dwc3_prepare_one_trb_linear -> dwc3_prepare_trbs_linear
>>>>
>>>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
>>> Tried to apply on top of -rc6:
>>>
>>> checking file drivers/usb/dwc3/gadget.c
>>> Hunk #1 FAILED at 1161.
>>> Hunk #2 FAILED at 1231.
>>> Hunk #3 FAILED at 1266.
>>> Hunk #4 FAILED at 1294.
>>> 4 out of 4 hunks FAILED
>>>
>>
>> I'll rebase send out a new series with a bunch of fixes.
>>
>> Btw, the patches you just merged are not the latest:
>> usb: dwc3: gadget: Resume pending requests after CLEAR_STALL
>> usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command
>>
>> The latest are on your "testing/fixes" branch
>
> Argh, nice catch. I'll fix it shortly.

should be corrected now. Thanks

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]