From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Bart Van Assche <bart.vanassche@wdc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
Romain Izard <romain.izard.pro@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Hannes Reinecke <hare@suse.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Subject: Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"
Date: Tue, 12 Dec 2017 12:49:35 +0200 [thread overview]
Message-ID: <87shcgnruo.fsf@linux.intel.com> (raw)
Hi again,
Felipe Balbi <felipe.balbi@linux.intel.com> writes:
> Bart Van Assche <bart.vanassche@wdc.com> writes:
>> Romain Izard reported the following about commit 7a9618a22aad:
>>
>> As it reached Linus' tree with v4.15-rc3, I recently noticed the
>> following commit that triggered a Kconfig request. I believe that this
>> change does not make sense.
>>
>> 7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH
>>
>> USB_ETH was not a dependency, but a default value for the choice. As the
>> choice was marked as "optional", it was possible to remove this value
>> when building.
>>
>> After this modification, the Kconfig choice option does not contain
>> anything anymore, so it is useless. It is also possible to select
>> multiple built-in legacy drivers. This builds, but will not work as
>> expected as only one legacy driver can be bound to an USB device
>> controller at a time.
>>
>> Hence revert commit 7a9618a22aad.
>>
>> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
>> Cc: Romain Izard <romain.izard.pro@gmail.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Hannes Reinecke <hare@suse.com>
>> Cc: Nicholas Bellinger <nab@linux-iscsi.org>
>> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>> Cc: linux-usb@vger.kernel.org
>> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
>
> this doesn't apply at all. Patch is not properly formatted.
I'll revert the commit manually just to get this fixed upstream.
next reply other threads:[~2017-12-12 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 10:49 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-12 10:45 Revert "usb: gadget: allow to enable legacy drivers without USB_ETH" Felipe Balbi
2017-12-11 16:51 Arnd Bergmann
2017-12-11 16:45 Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shcgnruo.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=andrzej.p@samsung.com \
--cc=arnd@arndb.de \
--cc=bart.vanassche@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=linux-usb@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=romain.izard.pro@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).