From: "Bjørn Mork" <bjorn@mork.no>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org,
Sebastian Sjoholm <sebastian.sjoholm@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: fix Quectel BG96 matching
Date: Tue, 01 Dec 2020 11:21:42 +0100 [thread overview]
Message-ID: <87tut5bzd5.fsf@miraculix.mork.no> (raw)
In-Reply-To: <X8YYdVk7LQ+VcpPf@localhost> (Johan Hovold's message of "Tue, 1 Dec 2020 11:18:29 +0100")
Johan Hovold <johan@kernel.org> writes:
> On Tue, Dec 01, 2020 at 11:03:18AM +0100, Bjørn Mork wrote:
>> This is a partial revert of commit 2bb70f0a4b23 ("USB: serial:
>> option: support dynamic Quectel USB compositions")
>>
>> The Quectel BG96 is different from most other modern Quectel modems,
>> having serial functions with 3 endpoints using ff/ff/ff and ff/fe/ff
>> class/subclass/protocol. Including it in the change to accommodate
>> dynamic function mapping was incorrect.
>>
>> Revert to interface number matching for the BG96, assuming static
>> layout of the RMNET function on interface 4. This restores support
>> for the serial functions on interfaces 2 and 3.
>>
>> Full lsusb output for the BG96:
>
>> Cc: Sebastian Sjoholm <sebastian.sjoholm@gmail.com>
>> Cc: linux-stable@vger.kernel.org
>> Fixes: 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions")
>> Signed-off-by: Bjørn Mork <bjorn@mork.no>
>
> Thanks, Bjørn. Now applied.
Thanks. But I see that I managed to type the stable address wrong.
Sorry. Hope you can get that fixed somehow.
Patch for checkpatch next, I guess...
Bjørn
next prev parent reply other threads:[~2020-12-01 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 10:03 [PATCH] USB: serial: option: fix Quectel BG96 matching Bjørn Mork
2020-12-01 10:18 ` Johan Hovold
2020-12-01 10:21 ` Bjørn Mork [this message]
2020-12-01 10:24 ` Johan Hovold
2020-12-01 16:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tut5bzd5.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.sjoholm@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox