From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>Thinh Nguyen
<thinh.nguyen@synopsys.com>,
Linux USB <linux-usb@vger.kernel.org>
Subject: [1/4] usb: dwc3: gadget: clear DWC3_EP_TRANSFER_STARTED on cmd complete
Date: Wed, 13 Feb 2019 09:11:30 +0200 [thread overview]
Message-ID: <87tvh840yl.fsf@linux.intel.com> (raw)
Hi,
Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
<snip>
>> Note that start transfer came before End Transfer completion.
>>
>> /me goes look furter
>>
>> I can see what's going on. The problem here is that we issue a Start
>> Transfer to all bulk endpoints when they are enabled. Upon ep_disable,
>> we issue End Transfer. Because you're switching interfaces all the time,
>> then you exposed the race between ep_disable followed by ep_enable and
>> End Transfer completion.
>>
>> Would it be enough to just skip the completion interrupt from
>> ep_disable?
>>
>>
>
> Your patch resolves this issue. Can you create a formal patch for this?
will do, thanks
next reply other threads:[~2019-02-13 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 7:11 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-13 2:32 [1/4] usb: dwc3: gadget: clear DWC3_EP_TRANSFER_STARTED on cmd complete Thinh Nguyen
2019-02-01 6:32 Felipe Balbi
2019-02-01 2:30 Thinh Nguyen
2019-01-24 7:24 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvh840yl.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=thinh.nguyen@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).