* [1/2] usb: dwc2: gadget: Fix WkupAlert interrupt handler.
@ 2018-10-30 12:26 Artur Petrosyan
0 siblings, 0 replies; 3+ messages in thread
From: Artur Petrosyan @ 2018-10-30 12:26 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Minas Harutyunyan, linux-usb
Cc: John Youn, Artur Petrosyan
According to the databook DCTL_RMTWKUPSIG bit
is defined in DCTL register not in DCFG.
Updated setting DCTL_RMTWKUPSIG bit to DCTL
register.
Signed-off-by: Artur Petrosyan <arturp@synopsys.com>
Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 2d6d2c8244de..6bd4054e894d 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -262,7 +262,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
- dwc2_set_bit(hsotg, DCFG, DCTL_RMTWKUPSIG);
+ dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [1/2] usb: dwc2: gadget: Fix WkupAlert interrupt handler.
@ 2018-10-30 12:33 Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2018-10-30 12:33 UTC (permalink / raw)
To: Artur Petrosyan, Greg Kroah-Hartman, Minas Harutyunyan, linux-usb
Cc: John Youn
Hi,
Artur Petrosyan <arthur.petrosyan@synopsys.com> writes:
> According to the databook DCTL_RMTWKUPSIG bit
> is defined in DCTL register not in DCFG.
>
> Updated setting DCTL_RMTWKUPSIG bit to DCTL
> register.
>
looks like this needs a Cc stable and Fixes tag. Care to add?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [1/2] usb: dwc2: gadget: Fix WkupAlert interrupt handler.
@ 2018-10-30 14:13 Artur Petrosyan
0 siblings, 0 replies; 3+ messages in thread
From: Artur Petrosyan @ 2018-10-30 14:13 UTC (permalink / raw)
To: Felipe Balbi, Artur Petrosyan, Greg Kroah-Hartman,
Minas Harutyunyan, linux-usb@vger.kernel.org
Cc: John Youn
Hi Balbi,
On 10/30/2018 16:34, Felipe Balbi wrote:
>
> Hi,
>
> Artur Petrosyan <arthur.petrosyan@synopsys.com> writes:
>> According to the databook DCTL_RMTWKUPSIG bit
>> is defined in DCTL register not in DCFG.
>>
>> Updated setting DCTL_RMTWKUPSIG bit to DCTL
>> register.
>>
>
> looks like this needs a Cc stable and Fixes tag. Care to add?
>
>
I think, we don't need to add this patch to stable as this code is not
included in any stable version. According Greg's mail ([GIT PULL] USB
driver patches for 4.20-rc1) this code first appeared in 4.20-rc1.
I will add the Fixes tag to the patch and send it with version 2.
Regards,
Artur
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-30 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30 12:33 [1/2] usb: dwc2: gadget: Fix WkupAlert interrupt handler Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-10-30 14:13 Artur Petrosyan
2018-10-30 12:26 Artur Petrosyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).