linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>Thinh Nguyen
	<Thinh.Nguyen@synopsys.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	John Youn <John.Youn@synopsys.com>
Subject: [2/3] usb: dwc3: gadget: Don't skip updating remaining data
Date: Fri, 03 Aug 2018 10:54:19 +0300	[thread overview]
Message-ID: <87va8rubpw.fsf@linux.intel.com> (raw)

Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> On 8/2/2018 12:46 AM, Felipe Balbi wrote:
>> Hi,
>>
>> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>
>> <snip>
>>
>>>> These patches will not fix the issue.
>>>>
>>> What do you think of this fix?
>>>
>>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>>> index f452ab708ffc..338f7ab8a8b4 100644
>>> --- a/drivers/usb/dwc3/gadget.c
>>> +++ b/drivers/usb/dwc3/gadget.c
>>> @@ -2277,8 +2277,10 @@ static int
>>> dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep,
>>>          * with one TRB pending in the ring. We need to manually clear
>>> HWO bit
>>>          * from that TRB.
>>>          */
>>> -       if ((req->zero || req->unaligned) && (trb->ctrl & DWC3_TRB_CTRL_HWO)) {
>>> -               trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
>>> +       if ((req->zero || req->unaligned) && !chain) {
>>> +               if (trb->ctrl & DWC3_TRB_CTRL_HWO)
>>> +                       trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
>>> +
>>>                 return 1;
>>>         }
>> This is a rathher minimal fix. I like it. So this together with the one
>> I wrote for the TRB type, right? Can you send this one as a proper patch
>> and add the correct Cc stable and Fixes tags?
>>
> Yes. Can you create an official patch for that TRB type issue you found?

Just sent it out, you're on Cc

             reply	other threads:[~2018-08-03  7:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  7:54 Felipe Balbi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-08-03  3:20 [2/3] usb: dwc3: gadget: Don't skip updating remaining data Thinh Nguyen
2018-08-02  7:43 Felipe Balbi
2018-08-02  7:28 Felipe Balbi
2018-08-02  1:54 Thinh Nguyen
2018-08-02  1:26 Thinh Nguyen
2018-08-01  8:29 Felipe Balbi
2018-08-01  6:48 Felipe Balbi
2018-08-01  6:36 Felipe Balbi
2018-07-31  6:55 Felipe Balbi
2018-07-30 22:23 Thinh Nguyen
2018-07-30  6:05 Felipe Balbi
2018-07-28  1:52 Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87va8rubpw.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=John.Youn@synopsys.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).