From: "Bjørn Mork" <bjorn@mork.no>
To: Greg KH <greg@kroah.com>
Cc: SARDARUDDIN SYED <ssardaruddin2002@gmail.com>,
linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: ABI: remove outdated USB power/level removal notice
Date: Thu, 04 Jun 2026 11:38:42 +0200 [thread overview]
Message-ID: <87wlweir19.fsf@miraculix.mork.no> (raw)
In-Reply-To: <2026060423-ipod-tarantula-4f5d@gregkh> (Greg KH's message of "Thu, 4 Jun 2026 08:45:57 +0200")
Greg KH <greg@kroah.com> writes:
>> I looked into the history and current implementation of power/level.
>>
>> The attribute is still implemented in drivers/usb/core/sysfs.c and is still
>> documented as a deprecated interface. The obsolete ABI entry was added when
>> power/level was deprecated in favor of power/control, but the interface
>> itself remains present.
>>
>> I wasn't sure whether you meant removing the obsolete documentation entry
>> or removing the deprecated interface itself, so I wanted to clarify before
>> sending a v2.
>
> Why not remove both?
Won't that break stuff for anyone still using the power/level attribute?
Time has proved that no one cares about deprecation warnings.
Why not implement Alans original wish in commit a90309860b09 ("USB:
deprecate the power/level sysfs attribute") instead:
It would be nice to replace power/level with a symlink to
power/control, but at the moment sysfs doesn't offer any way to do so.
I believe this has been possible since commit 9255782f7061 ("sysfs: Wrap
__compat_only_sysfs_link_entry_to_kobj function to change the symlink
name")
Bjørn
prev parent reply other threads:[~2026-06-04 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 23:34 [PATCH] Documentation: ABI: remove outdated USB power/level removal notice Sardaruddin Syed
2026-05-31 7:50 ` Greg KH
[not found] ` <CAEUfWQg7msH_qsER7nL5_855puJYsj4ztT+DrRThfbih8TObnw@mail.gmail.com>
2026-06-04 6:45 ` Greg KH
2026-06-04 9:38 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wlweir19.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ssardaruddin2002@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox