From: Felipe Balbi <balbi@kernel.org>
To: John Stultz <john.stultz@linaro.org>, Jack Pham <jackp@codeaurora.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Pratham Pratap <prathampratap@codeaurora.org>,
Yang Fei <fei.yang@intel.com>, Thinh Nguyen <thinhn@synopsys.com>,
Tejas Joglekar <tejas.joglekar@synopsys.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
Todd Kjos <tkjos@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
Linux USB List <linux-usb@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Update chain bit correctly when using sg list
Date: Wed, 19 Feb 2020 11:29:08 +0200 [thread overview]
Message-ID: <87wo8jexi3.fsf@kernel.org> (raw)
In-Reply-To: <CALAqxLUSU4j3G6zBsxeOanF2A4fi-Q+JKu6FVDXOwAzpnZvWNQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
Hi,
John Stultz <john.stultz@linaro.org> writes:
>> unsigned chain = (i < remaining - 1);
>>
>
> Personally, I think doing it via the conditional makes the logic a bit
> less taxing to read/skim. So I might keep that bit as is.
I agree, it's easier to follow the code. Compiler is, mostly, likely
optimizing that anyway.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-02-19 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 23:51 [PATCH] usb: dwc3: gadget: Update chain bit correctly when using sg list John Stultz
2020-02-19 0:07 ` Jack Pham
2020-02-19 0:21 ` John Stultz
2020-02-19 9:29 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo8jexi3.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=andrzej.p@collabora.com \
--cc=fei.yang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prathampratap@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=tejas.joglekar@synopsys.com \
--cc=thinhn@synopsys.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).