From: Felipe Balbi <balbi@kernel.org>
To: Chris Dickens <christopher.a.dickens@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb <linux-usb@vger.kernel.org>,
andrzej.p@samsung.com,
Chris Dickens <christopher.a.dickens@gmail.com>
Subject: Re: [PATCH] usb: gadget: composite: Remove dedicated OS Feature Descriptors request
Date: Sat, 25 Jul 2020 09:12:35 +0300 [thread overview]
Message-ID: <87y2n8nmwc.fsf@kernel.org> (raw)
In-Reply-To: <20200703083534.5292-1-christopher.a.dickens@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi,
Chris Dickens <christopher.a.dickens@gmail.com> writes:
> Currently Microsoft OS Feature Descriptors are handled using a
> separately allocated USB request, however everything about this USB
> request is identical to the USB request used for all other control
> responses. Simplify the code by removing this separate USB request and
> using the same USB request as all other control responses.
>
> While at it, simplify the composite_ep0_queue() function by removing the
> req and gfp_flags arguments. The former is no longer necessary with a
> single USB request and the latter is always GFP_ATOMIC.
I would rather move the removal of the extra arguments to a separate
patch.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-07-25 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 0:11 gadget: Why do Microsoft OS descriptors need their own USB request? Chris Dickens
2020-07-03 6:00 ` Greg Kroah-Hartman
2020-07-03 6:47 ` Chris Dickens
2020-07-03 6:57 ` Greg Kroah-Hartman
2020-07-03 7:03 ` Chris Dickens
2020-07-03 7:24 ` Greg Kroah-Hartman
2020-07-03 8:35 ` [PATCH] usb: gadget: composite: Remove dedicated OS Feature Descriptors request Chris Dickens
2020-07-03 8:57 ` Greg Kroah-Hartman
2020-07-25 6:12 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2n8nmwc.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=andrzej.p@samsung.com \
--cc=christopher.a.dickens@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).