linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields
@ 2018-01-05 20:13 Thinh Nguyen
  0 siblings, 0 replies; 3+ messages in thread
From: Thinh Nguyen @ 2018-01-05 20:13 UTC (permalink / raw)
  To: Felipe Balbi, Thinh Nguyen, linux-usb; +Cc: John Youn

Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP
is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM.

The GTXFIFOSIZ register for DWC_usb31 is as follows:
 +-------+-----------+----------------------------------+
 | BITS  | Name      | Description                      |
 +=======+===========+==================================+
 | 31:16 | TXFSTADDR | Transmit FIFOn RAM Start Address |
 | 15    | TXFRAMNUM | Asynchronous/Periodic TXFIFO     |
 | 14:0  | TXFDEP    | TXFIFO Depth                     |
 +-------+-----------+----------------------------------+

Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
 drivers/usb/dwc3/core.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4a4a4c98508c..6ebf7ddc547d 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -239,6 +239,8 @@
 #define DWC3_GUSB3PIPECTL_TX_DEEPH(n)	((n) << 1)
 
 /* Global TX Fifo Size Register */
+#define DWC3_USB31_GTXFIFOSIZ_TXFRAMNUM	BIT(15)		/* DWC_usb31 only */
+#define DWC3_USB31_GTXFIFOSIZ_TXFDEF(n)	((n) & 0x7fff)	/* DWC_usb31 only */
 #define DWC3_GTXFIFOSIZ_TXFDEF(n)	((n) & 0xffff)
 #define DWC3_GTXFIFOSIZ_TXFSTADDR(n)	((n) & 0xffff0000)
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields
@ 2018-01-08 12:01 Felipe Balbi
  0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2018-01-08 12:01 UTC (permalink / raw)
  To: Thinh Nguyen; +Cc: John Youn

Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP
> is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM.
>
> The GTXFIFOSIZ register for DWC_usb31 is as follows:
>  +-------+-----------+----------------------------------+
>  | BITS  | Name      | Description                      |
>  +=======+===========+==================================+
>  | 31:16 | TXFSTADDR | Transmit FIFOn RAM Start Address |
>  | 15    | TXFRAMNUM | Asynchronous/Periodic TXFIFO     |
>  | 14:0  | TXFDEP    | TXFIFO Depth                     |
>  +-------+-----------+----------------------------------+
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>  drivers/usb/dwc3/core.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 4a4a4c98508c..6ebf7ddc547d 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -239,6 +239,8 @@
>  #define DWC3_GUSB3PIPECTL_TX_DEEPH(n)	((n) << 1)
>  
>  /* Global TX Fifo Size Register */
> +#define DWC3_USB31_GTXFIFOSIZ_TXFRAMNUM	BIT(15)		/* DWC_usb31 only */
> +#define DWC3_USB31_GTXFIFOSIZ_TXFDEF(n)	((n) & 0x7fff)	/* DWC_usb31 only */

just to make it shorter, do you mind replacing DWC3_USB31 with DWC31 ?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields
@ 2018-01-08 23:22 Thinh Nguyen
  0 siblings, 0 replies; 3+ messages in thread
From: Thinh Nguyen @ 2018-01-08 23:22 UTC (permalink / raw)
  To: Felipe Balbi, Thinh Nguyen, linux-usb@vger.kernel.org; +Cc: John Youn

On 1/8/2018 4:02 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP
>> is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM.
>>
>> The GTXFIFOSIZ register for DWC_usb31 is as follows:
>>   +-------+-----------+----------------------------------+
>>   | BITS  | Name      | Description                      |
>>   +=======+===========+==================================+
>>   | 31:16 | TXFSTADDR | Transmit FIFOn RAM Start Address |
>>   | 15    | TXFRAMNUM | Asynchronous/Periodic TXFIFO     |
>>   | 14:0  | TXFDEP    | TXFIFO Depth                     |
>>   +-------+-----------+----------------------------------+
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
>> ---
>>   drivers/usb/dwc3/core.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index 4a4a4c98508c..6ebf7ddc547d 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -239,6 +239,8 @@
>>   #define DWC3_GUSB3PIPECTL_TX_DEEPH(n)	((n) << 1)
>>   
>>   /* Global TX Fifo Size Register */
>> +#define DWC3_USB31_GTXFIFOSIZ_TXFRAMNUM	BIT(15)		/* DWC_usb31 only */
>> +#define DWC3_USB31_GTXFIFOSIZ_TXFDEF(n)	((n) & 0x7fff)	/* DWC_usb31 only */
> 
> just to make it shorter, do you mind replacing DWC3_USB31 with DWC31 ?
> 

Sure, I'll make the change.

Thanks,
Thinh
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-08 23:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 12:01 [03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2018-01-08 23:22 Thinh Nguyen
2018-01-05 20:13 Thinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).