linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	USB list <linux-usb@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection
Date: Sat, 09 May 2020 11:02:13 +0300	[thread overview]
Message-ID: <87zhahlenu.fsf@kernel.org> (raw)
In-Reply-To: <CAAeHK+yxoYigM7uWC3cpKmCjgMLXQ1pT=MkJ7XQYCVRgZ-DdTQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]


Hi,

Andrey Konovalov <andreyknvl@google.com> writes:
>> here you're changing userspace ABI. Aren't we going to possibly break
>> some existing applications?
>
> Hi Felipe,
>
>  I've been working on tests for Raw Gadget for the last few weeks [1],
> which revealed a few problems with the interface. This isn't yet
> included into any released kernel, so my hope that changing the ABI is
> OK during the rc stage.

Fair enough. If that's okay with Greg, it's okay with me, but then how
do we include it into the -rc seen as it's not really a fix?

Greg, are you okay with me including such large patches during the -rc?
They essentially add new IOCTLs to the raw-gadget interface.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2020-05-09  8:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 22:09 [PATCH v2] usb: raw-gadget: fix gadget endpoint selection Andrey Konovalov
2020-05-05  7:34 ` Felipe Balbi
2020-05-05 12:08   ` Andrey Konovalov
2020-05-05 15:26     ` Andrey Konovalov
2020-05-07 15:01       ` Andrey Konovalov
2020-05-09  8:02     ` Felipe Balbi [this message]
2020-05-09 17:08       ` Greg Kroah-Hartman
2020-05-12  6:40         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhahlenu.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).