From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: lihuya <lihuya@hust.edu.cn>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <hust-os-kernel-patches@googlegroups.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq
Date: Tue, 25 Apr 2023 11:57:18 +0300 [thread overview]
Message-ID: <887b6226-ea4f-e75c-bfde-0785ccf30c77@omp.ru> (raw)
In-Reply-To: <20230424105930.49944-1-lihuya@hust.edu.cn>
Hello!
On 4/24/23 1:59 PM, lihuya wrote:
> platform_get_irq() only return non-zero irq number on success, or
> negative error number on failure.
>
> There is no need to check the return value of platform_get_irq()
> to determine the return value of dwc3_otg_get_irq(), removing
> them to solve this problem.
I was going to submit such patch myself at some point... which
has never happened. :-/
> Signed-off-by: lihuya <lihuya@hust.edu.cn>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2023-04-25 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 10:59 [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq lihuya
2023-04-24 21:33 ` Thinh Nguyen
2023-04-24 23:29 ` Dongliang Mu
2023-04-25 8:57 ` Sergey Shtylyov [this message]
2023-04-25 9:10 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887b6226-ea4f-e75c-bfde-0785ccf30c77@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=lihuya@hust.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox