From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Russell King <linux@armlinux.org.uk>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH RFC v4 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors
Date: Sun, 1 Oct 2023 20:39:03 +0200 [thread overview]
Message-ID: <8c101322-085b-451c-90b6-90d2799ef192@skole.hr> (raw)
In-Reply-To: <CAHp75VcBY3W8aVEsRMPNMW9940yT+_=-w8J2uKfqvmUiAVjPhg@mail.gmail.com>
On 10/1/2023 4:32 PM, Andy Shevchenko wrote:
>> + pxa_ohci->usb_host = gpiod_get_optional(&pdev->dev, "usb-host", GPIOD_OUT_LOW);
>> + if (IS_ERR(pxa_ohci->usb_host))
>> + dev_warn(&pdev->dev, "failed to get USB host GPIO with %pe\n",
>> + pxa_ohci->usb_host);
>
> Since you are using _optional() API, you need to bail out on the error
> case and replace dev_warn() by dev_err(). I guess I already commented
> on this. What is the rationale to not follow my comment?
I must have missed it, sorry about that. I'll be sure to do so in v5.
Regards,
Duje
next prev parent reply other threads:[~2023-10-01 18:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 14:12 [PATCH RFC v4 0/6] ARM: pxa: GPIO descriptor conversions Duje Mihanović
2023-10-01 14:12 ` [PATCH RFC v4 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors Duje Mihanović
2023-10-01 14:32 ` Andy Shevchenko
2023-10-01 18:39 ` Duje Mihanović [this message]
2023-10-01 14:12 ` [PATCH RFC v4 2/6] ARM: pxa: Convert Spitz LEDs " Duje Mihanović
2023-10-01 14:34 ` Andy Shevchenko
2023-10-02 7:36 ` Bartosz Golaszewski
2023-10-02 8:54 ` Linus Walleij
2023-10-01 14:12 ` [PATCH RFC v4 3/6] ARM: pxa: Convert Spitz CF power control " Duje Mihanović
2023-10-01 14:12 ` [PATCH RFC v4 4/6] ARM: pxa: Convert reset driver " Duje Mihanović
2023-10-01 14:40 ` Andy Shevchenko
2023-10-01 14:50 ` Andy Shevchenko
2023-10-01 14:12 ` [PATCH RFC v4 5/6] ARM: pxa: Convert gumstix Bluetooth " Duje Mihanović
2023-10-02 7:42 ` Bartosz Golaszewski
2023-10-02 14:52 ` Duje Mihanović
2023-10-02 17:09 ` Bartosz Golaszewski
2023-10-01 14:12 ` [PATCH RFC v4 6/6] input: ads7846: Move wait_for_sync() logic to driver Duje Mihanović
2023-10-01 14:56 ` Andy Shevchenko
2023-10-02 8:59 ` Linus Walleij
2023-10-02 11:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c101322-085b-451c-90b6-90d2799ef192@skole.hr \
--to=duje.mihanovic@skole.hr \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox