From: "Wang, Sheng Long" <shenglong.wang.ext@siemens.com>
To: Johan Hovold <johan@kernel.org>
Cc: Sheng Long Wang <china_shenglong@163.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: RE: [PATCH v3] usb-serial:cp210x: add support to software flow control
Date: Mon, 24 Aug 2020 10:16:13 +0000 [thread overview]
Message-ID: <8f7594e92e464bd4bd2e51218541ed58@siemens.com> (raw)
In-Reply-To: <20200824094307.GE21288@localhost>
Hi, Johan
So, Is it currently possible for me to use which Branch? :)
https://github.com/torvalds/linux master branch
Or use https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
Thanks!
BR/Sheng Long
-----Original Message-----
From: Johan Hovold <johan@kernel.org>
Sent: Monday, August 24, 2020 5:43 PM
To: Kiszka, Jan (CT RDA IOT SES-DE) <jan.kiszka@siemens.com>
Cc: Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) <shenglong.wang.ext@siemens.com>; Johan Hovold <johan@kernel.org>; Sheng Long Wang <china_shenglong@163.com>; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software flow control
On Mon, Aug 24, 2020 at 11:36:50AM +0200, Jan Kiszka wrote:
> On 24.08.20 11:28, Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) wrote:
> > Hi Johan,
> >
> > Thanks for your reminding. I am adjusting patch according to the latest Linux Master branch.
>
> Use git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git,
> branch is likely usb-linus, as Johan requested - just in case there is
> another conflict due to a patch not yet in Linux master but in that tree.
The usb-next is used for new features like this one, but again, currently Linus's master branch works as well.
> > -----Original Message-----
> > From: Johan Hovold <johan@kernel.org>
> > Sent: Monday, August 24, 2020 5:10 PM
> > To: Kiszka, Jan (CT RDA IOT SES-DE) <jan.kiszka@siemens.com>
> > Cc: Sheng Long Wang <china_shenglong@163.com>; Wang, Sheng Long
> > (EXT) (RC-CN DI FA R&D SW) <shenglong.wang.ext@siemens.com>;
> > johan@kernel.org; gregkh@linuxfoundation.org;
> > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software
> > flow control
> >
> > On Fri, Aug 21, 2020 at 07:32:58AM +0200, Jan Kiszka wrote:
> >> On 20.08.20 09:52, Sheng Long Wang wrote:
> >>> From: Wang Sheng Long <shenglong.wang.ext@siemens.com>
> >>>
> >>> When data is transmitted between two serial ports, the phenomenon
> >>> of data loss often occurs. The two kinds of flow control commonly
> >>> used in serial communication are hardware flow control and
> >>> software flow control.
> >>>
> >>> In serial communication, If you only use RX/TX/GND Pins, you can't
> >>> do hardware flow. So we often used software flow control and
> >>> prevent data loss. The user sets the software flow control through
> >>> the application program, and the application program sets the
> >>> software flow control mode for the serial port chip through the driver.
> >>>
> >>> For the cp210 serial port chip, its driver lacks the software flow
> >>> control setting code, so the user cannot set the software flow
> >>> control function through the application program. This adds the
> >>> missing software flow control.
> >>>
> >>> Signed-off-by: Wang Sheng Long <shenglong.wang.ext@siemens.com>
> >>>
> >>> Changes in v3:
> >>> -fixed code style, It mainly adjusts the code style acccording to
> >>> kernel specification.
> >>
> >> Patch does not apply. You forgot to rebase over latest tty/tty-next
> >> or linux master.
> >
> > That should be the usb-next branch of the usb-serial tree:
> >
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
> > /
> >
> > or linux-next (or, currently, Linus's master branch).
> >
> > You can use "scripts/get_maintainer.sh --scm" to determine which tree to base your work against.
>
> Thanks for correcting! But it's scripts/get_maintainer.pl. ;)
Heh. Thanks for catching that.
Johan
next prev parent reply other threads:[~2020-08-24 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 7:52 [PATCH v3] usb-serial:cp210x: add support to software flow control Sheng Long Wang
2020-08-21 5:32 ` Jan Kiszka
2020-08-24 9:09 ` Johan Hovold
2020-08-24 9:28 ` Wang, Sheng Long
2020-08-24 9:36 ` Jan Kiszka
2020-08-24 9:43 ` Johan Hovold
2020-08-24 10:16 ` Wang, Sheng Long [this message]
2020-08-24 11:16 ` Johan Hovold
2020-08-24 9:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f7594e92e464bd4bd2e51218541ed58@siemens.com \
--to=shenglong.wang.ext@siemens.com \
--cc=china_shenglong@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).