From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693E6C433DF for ; Mon, 24 Aug 2020 10:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E848207DF for ; Mon, 24 Aug 2020 10:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbgHXKQT convert rfc822-to-8bit (ORCPT ); Mon, 24 Aug 2020 06:16:19 -0400 Received: from gw-eagle1.siemens.com ([194.138.20.72]:13465 "EHLO gw-eagle1.siemens.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgHXKQT (ORCPT ); Mon, 24 Aug 2020 06:16:19 -0400 Received: from mail2.dc4ca.siemens.de (mail2.dc4ca.siemens.de [139.25.224.94]) by gw-eagle1.siemens.com (Postfix) with ESMTPS id B17CF4F000C; Mon, 24 Aug 2020 12:16:16 +0200 (CEST) Received: from DEMCHDC8A0A.ad011.siemens.net (demchdc8a0a.ad011.siemens.net [139.25.226.106]) by mail2.dc4ca.siemens.de (Postfix) with ESMTPS id A09241552FD70; Mon, 24 Aug 2020 12:16:16 +0200 (CEST) Received: from CNPEK01M06MSX.ad011.siemens.net (139.24.237.223) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Mon, 24 Aug 2020 12:16:15 +0200 Received: from CNPEK01M06MSX.ad011.siemens.net ([139.24.237.223]) by CNPEK01M06MSX.ad011.siemens.net ([139.24.237.223]) with mapi id 15.01.2044.004; Mon, 24 Aug 2020 18:16:13 +0800 From: "Wang, Sheng Long" To: Johan Hovold CC: Sheng Long Wang , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Kiszka, Jan" Subject: RE: [PATCH v3] usb-serial:cp210x: add support to software flow control Thread-Topic: [PATCH v3] usb-serial:cp210x: add support to software flow control Thread-Index: AQHWdscbn5u/RYWMnkqBpjeEIyjP+KlBhWMAgATzlACAAInCwP//fcsAgAABwoCAAIlwwA== Date: Mon, 24 Aug 2020 10:16:13 +0000 Message-ID: <8f7594e92e464bd4bd2e51218541ed58@siemens.com> References: <20200820075240.13321-1-china_shenglong@163.com> <97836b78-740b-cf70-4803-27305b6e0a4d@siemens.com> <20200824090948.GC21288@localhost> <20200824094307.GE21288@localhost> In-Reply-To: <20200824094307.GE21288@localhost> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcejAwNDNjYnhcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy1kNTExZjY4MC1lNWYyLTExZWEtYmU1OS1iMDBjZDE2OTA4NjRcYW1lLXRlc3RcZDUxMWY2ODItZTVmMi0xMWVhLWJlNTktYjAwY2QxNjkwODY0Ym9keS50eHQiIHN6PSIzNzk1IiB0PSIxMzI0MjczNzc3MTc5NTI4NzMiIGg9InJOcG0xVXZ2UExhOTF2SWFMeHlaUTNvQmNIRT0iIGlkPSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQUhBQUFBQnBRV3FYLzNuV0FicEhzb1NSRFMwQnVrZXloSkVOTFFFQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUJBQUFBVGFuck9nQUFBQUFBQUFBQUFBQUFBQT09Ii8+PC9tZXRhPg== x-dg-rorf: x-document-confidentiality: NotClassified x-originating-ip: [139.24.108.238] x-tm-snts-smtp: 94F92D4091750FD798C19F9F04C1FE6D889768A1769DE3843207CD8ED0E527E12000:8 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Johan So, Is it currently possible for me to use which Branch? :) https://github.com/torvalds/linux master branch Or use https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git Thanks! BR/Sheng Long -----Original Message----- From: Johan Hovold Sent: Monday, August 24, 2020 5:43 PM To: Kiszka, Jan (CT RDA IOT SES-DE) Cc: Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) ; Johan Hovold ; Sheng Long Wang ; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software flow control On Mon, Aug 24, 2020 at 11:36:50AM +0200, Jan Kiszka wrote: > On 24.08.20 11:28, Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) wrote: > > Hi Johan, > > > > Thanks for your reminding. I am adjusting patch according to the latest Linux Master branch. > > Use git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git, > branch is likely usb-linus, as Johan requested - just in case there is > another conflict due to a patch not yet in Linux master but in that tree. The usb-next is used for new features like this one, but again, currently Linus's master branch works as well. > > -----Original Message----- > > From: Johan Hovold > > Sent: Monday, August 24, 2020 5:10 PM > > To: Kiszka, Jan (CT RDA IOT SES-DE) > > Cc: Sheng Long Wang ; Wang, Sheng Long > > (EXT) (RC-CN DI FA R&D SW) ; > > johan@kernel.org; gregkh@linuxfoundation.org; > > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software > > flow control > > > > On Fri, Aug 21, 2020 at 07:32:58AM +0200, Jan Kiszka wrote: > >> On 20.08.20 09:52, Sheng Long Wang wrote: > >>> From: Wang Sheng Long > >>> > >>> When data is transmitted between two serial ports, the phenomenon > >>> of data loss often occurs. The two kinds of flow control commonly > >>> used in serial communication are hardware flow control and > >>> software flow control. > >>> > >>> In serial communication, If you only use RX/TX/GND Pins, you can't > >>> do hardware flow. So we often used software flow control and > >>> prevent data loss. The user sets the software flow control through > >>> the application program, and the application program sets the > >>> software flow control mode for the serial port chip through the driver. > >>> > >>> For the cp210 serial port chip, its driver lacks the software flow > >>> control setting code, so the user cannot set the software flow > >>> control function through the application program. This adds the > >>> missing software flow control. > >>> > >>> Signed-off-by: Wang Sheng Long > >>> > >>> Changes in v3: > >>> -fixed code style, It mainly adjusts the code style acccording to > >>> kernel specification. > >> > >> Patch does not apply. You forgot to rebase over latest tty/tty-next > >> or linux master. > > > > That should be the usb-next branch of the usb-serial tree: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git > > / > > > > or linux-next (or, currently, Linus's master branch). > > > > You can use "scripts/get_maintainer.sh --scm" to determine which tree to base your work against. > > Thanks for correcting! But it's scripts/get_maintainer.pl. ;) Heh. Thanks for catching that. Johan