From: Neil Armstrong <neil.armstrong@linaro.org>
To: Venkat Jayaraman <venkat.jayaraman@intel.com>, linux-usb@vger.kernel.org
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
pse.type-c.linux@intel.com,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command
Date: Tue, 19 Aug 2025 11:47:58 +0200 [thread overview]
Message-ID: <91cb0acb-73c4-4d3a-9aa8-1056f367d82e@linaro.org> (raw)
In-Reply-To: <20250814163028.18058-1-venkat.jayaraman@intel.com>
Hi,
On 14/08/2025 18:30, Venkat Jayaraman wrote:
> Add support for UCSI READ_POWER_LEVEL command as per
> UCSI specification v2.1 and above to debugfs.
>
> Following power related fields will be exposed as files in debugfs:-
> peak_current (Peak current),
> avg_current (Average current) and
> vbus_voltage (VBUS voltage)
>
> These files will be updated either when a READ_POWER_LEVEL
> command is sent from OS or when a device is connected.
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Venkat Jayaraman <venkat.jayaraman@intel.com>
> ---
> Changelog v3:
> - Rebased to kernel 6.17-rc1
>
> Changelog v2:
> - Removed extra space in declaration
> - Made the call to debugfs_create_file single line for clarity
>
> drivers/usb/typec/ucsi/debugfs.c | 31 +++++++++++++++++++++++++++++++
> drivers/usb/typec/ucsi/ucsi.c | 16 ++++++++++++++++
> drivers/usb/typec/ucsi/ucsi.h | 13 +++++++++++++
> 3 files changed, 60 insertions(+)
>
This commit causes the following warning:
[ 8.646179] ------------[ cut here ]------------
[ 8.650986] Access to unsupported field at offset 0x59 (need version 0210)
[ 8.651044] WARNING: drivers/usb/typec/ucsi/ucsi.c:1296 at ucsi_handle_connector_change+0x380/0x414 [typec_ucsi], CPU#0: kworker/0:0/9
<snip>
[ 8.832491] Hardware name: Qualcomm Technologies, Inc. SM8550 HDK (DT)
[ 8.839228] Workqueue: events ucsi_handle_connector_change [typec_ucsi]
[ 8.846084] pstate: 63400005 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--)
[ 8.853277] pc : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
[ 8.860031] lr : ucsi_handle_connector_change+0x380/0x414 [typec_ucsi]
<snip>
[ 8.944023] Call trace:
[ 8.946570] ucsi_handle_connector_change+0x380/0x414 [typec_ucsi] (P)
[ 8.953328] process_one_work+0x148/0x28c
[ 8.957502] worker_thread+0x2c8/0x3d0
[ 8.961401] kthread+0x12c/0x204
[ 8.964759] ret_from_fork+0x10/0x20
[ 8.968474] ---[ end trace 0000000000000000 ]---
on:
8550-hdk:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253312#L1418
8550-qrd:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253306#L1560
8650-hdk:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253308#L1494
8650-qrd:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253309#L1594
x1-crd:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253311#L2226
x1-qcp:
https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/253310#L2160
I guess the version should be checked.
Neil
next prev parent reply other threads:[~2025-08-19 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 16:30 [PATCH v3] usb: typec: ucsi: Add support for READ_POWER_LEVEL command Venkat Jayaraman
2025-08-19 9:47 ` Neil Armstrong [this message]
2025-08-21 7:21 ` Heikki Krogerus
2025-09-01 7:49 ` Neil Armstrong
2025-09-02 1:59 ` Jayaraman, Venkat
2025-09-04 19:14 ` Jayaraman, Venkat
2025-09-04 20:17 ` Dmitry Baryshkov
2025-09-05 7:31 ` Heikki Krogerus
2025-09-05 7:13 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91cb0acb-73c4-4d3a-9aa8-1056f367d82e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pse.type-c.linux@intel.com \
--cc=venkat.jayaraman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).